Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make select and join combinators functions #1215

Closed
MajorBreakfast opened this issue Aug 19, 2018 · 0 comments · Fixed by #1538
Closed

Make select and join combinators functions #1215

MajorBreakfast opened this issue Aug 19, 2018 · 0 comments · Fixed by #1538

Comments

@MajorBreakfast
Copy link
Contributor

MajorBreakfast commented Aug 19, 2018

Currently the select and join combinators are methods. This leads to asymmetric code like this, which is harder to read (at least I always thought so):

future1.join(future2)

It has already been discussed in passing that making them symmetric by making them functions would be nice:

future::join3(future1, future2, future3)

This also makes them more similar to their already symmetric variadic macro counterparts join! and select! that work in async functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant