Unexpected string literal indents

[choubacha]

Rust 1.26 was just released and it appears to have changed some aspect of rustfmt as well. I ran cargo fmt on my repo (https://github.com/kbacha/stellar-sdk) and pushed the changes. However, it failed on CI because of a format issue. We run a format check so that we don't merge poorly formatted code:
https://travis-ci.org/kbacha/stellar-sdk/builds/377478444?utm_source=github_status&utm_medium=notification

I went local again and ran cargo fmt again and got:

and again:

Then I moved to another repo and recreated it here:
https://github.com/kbacha/cargo-fmt-err-1-26

It appears to only matter inside a macro_rules as far as I can tell.

[topecongiro]

Thank you for filing an issue!

I think that this is already fixed via #2589, but unfortunately the latest stable version (rustfmt 0.4.1-stable (7a80726 2018-04-20)) does not include the change.
Would you mind trying the nightly version of rustfmt? The issue should be fixed with it. Please refer to https://github.com/rust-lang-nursery/rustfmt#quick-start for how to install and use it.

[choubacha]

Yep, it does appear that it isn't broken in the nightly version. When do you think the next version will release?

[topecongiro]

AFAICT stable rustfmt shipped by rustup is infrequently update, only when the new rustc version is released. So I think that we have to wait for the next rustc's 1.27 release to see stable rustfmt gets updated.
Ping @nrc for more information, do you have a clear view on how rustup chooses the rustfmt version?

[nrc]

The version rustup chooses is the submodule on the branch in the Rust repo. We can't change that in stable/beta without doing a point release of Rust itself, which I don't think we can get away with for this.

Going to close this issue since it is fixed on master. As a work around I would recommend using beta or nightly, just for rustfmt'ing