From c4e660330d948dc7b0d5198dae35f06ee665f597 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 27 Mar 2024 10:20:53 +1100 Subject: [PATCH] Bump MSRV to 1.56.1 We want to depend on the newly released version of `hashes` which has an MSRV of 1.56.1 Bump the MSRV for the main crate `secp256k1` to Rust `v1.56.1` as it is for most of the rest of our crates. Leave `secp256k1-sys` as it is, and add a basic CI job to test we can run tests with default features using 1.48.0 still for that crate only. --- .github/workflows/rust.yml | 17 +++++++++++++++-- Cargo.toml | 3 ++- README.md | 2 +- 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 9297ba0c0..837b7babc 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -54,8 +54,8 @@ jobs: DO_ASAN: true run: ./contrib/test.sh - MSRV: - name: Test - 1.48.0 toolchain + MSRV-secp256k1-sys: + name: secp256k1-sys - test 1.48.0 runs-on: ubuntu-latest strategy: fail-fast: false @@ -64,6 +64,19 @@ jobs: uses: actions/checkout@v3 - name: Checkout Toolchain uses: dtolnay/rust-toolchain@1.48.0 + - name: Test default features + run: cd secp256k1-sys && cargo test + + MSRV: + name: Test - 1.56.1 toolchain + runs-on: ubuntu-latest + strategy: + fail-fast: false + steps: + - name: Checkout Crate + uses: actions/checkout@v3 + - name: Checkout Toolchain + uses: dtolnay/rust-toolchain@1.56.1 - name: Running test script env: DO_FEATURE_MATRIX: true diff --git a/Cargo.toml b/Cargo.toml index 942835bb7..b6e1dcf72 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -10,7 +10,8 @@ documentation = "https://docs.rs/secp256k1/" description = "Rust wrapper library for Pieter Wuille's `libsecp256k1`. Implements ECDSA and BIP 340 signatures for the SECG elliptic curve group secp256k1 and related utilities." keywords = [ "crypto", "ECDSA", "secp256k1", "libsecp256k1", "bitcoin" ] readme = "README.md" -edition = "2018" +edition = "2021" +rust-version = "1.56.1" [package.metadata.docs.rs] all-features = true diff --git a/README.md b/README.md index ca4efa31b..10ead79a1 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ Contributions to this library are welcome. A few guidelines: * Any breaking changes must have an accompanied entry in CHANGELOG.md * No new dependencies, please. * No crypto should be implemented in Rust, with the possible exception of hash functions. Cryptographic contributions should be directed upstream to libsecp256k1. -* This library should always compile with any combination of features on **Rust 1.48.0**. +* This library should always compile with any combination of features on **Rust 1.56.1**. ### Githooks