fixing race condition in the downloader

rusq · Feb 12, 2024 · 30d207d · 30d207d
1 parent 8096d26
commit 30d207d
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/downloader/downloader.go b/downloader/downloader.go
@@ -267,12 +267,11 @@ func (c *Client) Stop() {
 // ErrNotStarted. Will place the file to the download queue.
 func (c *Client) Download(fullpath string, url string) error {
 	c.mu.Lock()
-	started := c.started
-	c.mu.Unlock()
-
-	if !started {
+	defer c.mu.Unlock()
+	if !c.started {
 		return ErrNotStarted
 	}
+
 	c.requests <- Request{Fullpath: fullpath, URL: url}
 	return nil
 }