-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation of >=v7.0.1 fails with JRuby #2350
Comments
Using the gem from source via the I suspect that it's required to build two variants of the gem for each platform as the uploaded variant in |
Thanks, yes, that's basically what I have been doing as a work-around until a solution can be found, I.E.: git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem "activerecord-oracle_enhanced-adapter", github: "rsim/oracle-enhanced" |
I have the same problem, but loading from github is not an option for me, because of corporate firewall rules. Thus I cloned the repository, switched to the v7.0.3 tag and built the gem with jruby. jruby -S bundle
jruby -S bundle exec rake build I copied the resulting gem to vendor/cache and installed/updated with bundle update --local. This gem then works. So the problem is, that no jruby version of the gem has been published. |
In fact there was never a Java version published for this gem as you can see here but this was no issue so far because all dependencies were cross-compatible. Only the person(s) who publishes this gem can fix this. |
Thank you for pointing that out @davue, that explains it. And thank you for the link, I can now show what I discovered in the commit mentioned in the issue report.
|
I believe this commit (first released with v7.0.1) is causing the installation of the
activerecord-oracle_enhanced-adapter
gem to fail when using JRuby.Steps to reproduce
Passing (
7.0.0
):Failing (
7.0.1
):Expected behavior
The
activerecord-oracle_enhanced-adapter
gem should install without requiringruby-oci8
Actual behavior
The
ruby-oci8
gem is being required.System configuration
Rails version:
N/A
Oracle enhanced adapter version:
>= 7.0.1
Ruby version:
JRuby 9.4.3.0
Oracle Database version:
N/A
The text was updated successfully, but these errors were encountered: