Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomValidators.date does not work correctly in Safari. #11

Closed
Tolitech opened this issue Jul 27, 2018 · 6 comments
Closed

CustomValidators.date does not work correctly in Safari. #11

Tolitech opened this issue Jul 27, 2018 · 6 comments
Labels

Comments

@Tolitech
Copy link

Validation works correctly in Chrome, Firefox, Opera, IE, Edge.
However, any valid date is indicated as "invalid" in Safari.

"@angular/core": "^6.0.0",
"ngx-custom-validators": "^6.0.0"

Form Group:
initialDate: [this.item.initialDate, [CustomValidators.date]]

@rsaenen rsaenen added the bug label Jul 27, 2018
@rsaenen
Copy link
Owner

rsaenen commented Jul 27, 2018

As I have not a Mac, I won't be able to close this issue.
A PR is needed.

@Tolitech
Copy link
Author

Unfortunately I do not have it either.
I tested it on the ipad.
let's wait...

@rsaenen
Copy link
Owner

rsaenen commented Jul 27, 2018

That could be an issue specific to iOS. I’ll check with Stackblitz in a Apple Store...

@rsaenen
Copy link
Owner

rsaenen commented Aug 19, 2018

Released with 6.0.4, can you confirm the fix?

@Tolitech
Copy link
Author

I had to change some components to work together.
It works.
Thank you very much.

https://angular-blnggz.stackblitz.io/

@rsaenen
Copy link
Owner

rsaenen commented Aug 20, 2018

The fix has been released with 6.0.5.
6.0.4 has still a bug with Safari OS X and iOS.

FYI, "2018-8-20" is not a valid date but "2018-08-20" is. That was the mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants