Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly wrong R1 penalty #34

Closed
TropComplique opened this issue Aug 21, 2019 · 1 comment
Closed

Possibly wrong R1 penalty #34

TropComplique opened this issue Aug 21, 2019 · 1 comment

Comments

@TropComplique
Copy link

Hi.
Why do you use softplus before computing gradient here?
In the original implementation they don't do it. Look at this line.

@rosinality
Copy link
Owner

rosinality commented Aug 21, 2019

Thank you, corrected it at bc4bd85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants