Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress toward Quality Level 1 #66

Closed
21 of 22 tasks
Blast545 opened this issue Mar 6, 2020 · 2 comments · Fixed by #89
Closed
21 of 22 tasks

Progress toward Quality Level 1 #66

Blast545 opened this issue Mar 6, 2020 · 2 comments · Fixed by #89

Comments

@Blast545
Copy link
Contributor

Blast545 commented Mar 6, 2020

This issue tracks the progression of libconsole-bridge-dev to Quality Level 1 and a 1.0 version level. It will follow the outline described in REP 2004.

  • Version Policy
    • Follows ROS Core Quality Declaration
  • Version >= 1.0.0
  • Change Control Process
  • API and ABI stability within a ROS distribution
  • Vulnerability Disclosure Policy

Documentation

  • Per-feature documentation.
  • Per-item documentation in public API.
    • Uses docblocks
  • Declared set of licenses
  • Copyright statement in each source file
    • Checked manually. New source files will require having one.
  • Quality Declaration document

Testing:

  • System tests, which cover "features"
  • Tests covering public API
  • Code Coverage > 95%:
      • Must have code coverage tracking for the package -> here
      • Must have and enforce a code coverage policy for new changes Policy
  • Performance tests: not currently available.
  • Linters and Static Analysis:
      • Must have a code style and enforce it.
      • Must use static analysis tools where applicable:
        -- cppcheck and cpplint

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • None
  • non-ROS dependencies are equivalent level 1
    • None

Platform Support

  • Supports all tier 1 platforms as described in REP-2000
@chapulina
Copy link
Contributor

I think we can check the box for 95% coverage since #84 was merged.

@scpeters
Copy link
Contributor

I think we can check the box for 95% coverage since #84 was merged.

done. looks like performance tests are the last thing

@ahcorde ahcorde linked a pull request Sep 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants