Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Create a GH Action that runs cross-compile #67

Open
zmichaels11 opened this issue Nov 21, 2019 · 4 comments
Open

Create a GH Action that runs cross-compile #67

zmichaels11 opened this issue Nov 21, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@zmichaels11
Copy link
Contributor

zmichaels11 commented Nov 21, 2019

Description

The cross-compile workflow can be simplified by having a GH Action run cross-compile and upload the workspace as an artifact.

The intended output of this issue is to release a GitHub Action to the marketplace that ROS workspace repositories can use to run this tool to cross-compile the workspace and upload the artifacts.

Related Issues

N/A

Completion Criteria

  • A ROS github repository can use a GitHub Action from the marketplace to cross-compile their package to any platform supported by this tool, and download the built artifact when it is done.

Implementation Notes / Suggestions

Not filled out

Testing Notes / Suggestions

  • Integration+Manual Testing:
    • Add cross-compile GH action to a simple ROS2 project repo on GitHub
    • Verify (manually) that the ws image is valid
@thomas-moulard
Copy link
Member

thomas-moulard commented Nov 21, 2019

We already have an e2e test. We just need to enable it I guess? We don't need a separate logic from colcon test for that.

@zmichaels11
Copy link
Contributor Author

This isn't adding an e2e test, its creating a new github action for the marketplace to run cross_compile as a CICD step.

@thomas-moulard
Copy link
Member

Oh I get what you're saying now, how do you upload the ws, seems too big to be an artefact, does that incorporate pushing the docker image to the GitHub registry?

@zmichaels11
Copy link
Contributor Author

zmichaels11 commented Nov 21, 2019

GitHub is cool as long as its no more than 2GB per file

So tar.gz it I guess

@emersonknapp emersonknapp added the enhancement New feature or request label Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants