Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated macros of console_bridge in rosbag_storage/src/bz2_stream.cpp and lz2_stream.cpp #1

Closed
majorx234 opened this issue Jan 4, 2018 · 1 comment

Comments

@majorx234
Copy link

console-bridge renamed its logError function to CONSOLE_BRIDGE_logError.
See commit in cosnole_bridge

suggested solution:
rename these functions and add something like

#ifndef CONSOLE_BRIDGE_logError
  #define CONSOLE_BRIDGE_logError logError
#endif

to get backward compatiblity with libconsole-bridge-dev < 0.3.0,

@majorx234 majorx234 changed the title deprecated macros of console_bridge in rosbag_storage/src/bz2_stream.cpp deprecated macros of console_bridge in rosbag_storage/src/bz2_stream.cpp and lz2_stream.cpp Jan 4, 2018
@dirk-thomas
Copy link
Contributor

This has already been addressed upstream for Kinetic as well as Lunar: ros/ros_comm#1235, ros/ros_comm#1238.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants