Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using download_hydat without a keypress? #164

Closed
boshek opened this issue Sep 21, 2021 · 1 comment
Closed

Using download_hydat without a keypress? #164

boshek opened this issue Sep 21, 2021 · 1 comment

Comments

@boshek
Copy link
Collaborator

boshek commented Sep 21, 2021

👋 @rchlumsk.

Great point. Definitely should have a parameter. I see you've started some work. I think it would be best to have a parameter called ask which is a logical with default being TRUE. That was it won't break any existing code. Why don't you open that fork into a pull request and we can get this sorted?

Discussed in https://github.com/ropensci/tidyhydat/discussions/163

Originally posted by rchlumsk September 21, 2021
Hi there, is there a good way to use the download_hydat function without the keypress? Adding a present answer as a parameter to the download function would be one option, but wondering if there is any workaround the keypress in the existing function.

For context I am trying to use tidyhydat to update the HYDAT database in an external program, and would like to simply force it to update the database without the download time warning and question at the keypress.

Thanks!
Rob

@rchlumsk
Copy link
Contributor

I think this can now be closed with #165

@boshek boshek closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants