Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 290 for which the default generator was always used by the bootstrapped YCM #294

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

traversaro
Copy link
Member

Fix #290 .
This PR contains two fixes:

  • Add a missing semicolon ; to the ${_YCM_EP_CMAKE_CACHE_DEFAULT_ARGS} passed to the CMake invocation of the YCM boostrap: without that, the -G<Generator> command was considered as part of the last variable set in _YCM_EP_CMAKE_CACHE_DEFAULT_ARGS, and effectively ignored.
  • The previous error for some reason was preventing the use of | as list separtor in the -DCMAKE_PREFIX_PATH:PATH= argument of the CMake invocation to create problems, once fixed the CMake configuration was failing for this reason. As YCM bootstrap does not need to find anything using CMAKE_PREFIX_PATH, the easiest solution is just to remove it from the invocation command.

@drdanz drdanz merged commit f22618f into master Nov 13, 2019
@drdanz drdanz deleted the fix-290 branch November 13, 2019 10:48
@drdanz
Copy link
Member

drdanz commented Nov 13, 2019

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In YCM 0.10.4 bootstrapping is broken when using a generator different from the default one
2 participants