Fix issue 290 for which the default generator was always used by the bootstrapped YCM #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #290 .
This PR contains two fixes:
;
to the${_YCM_EP_CMAKE_CACHE_DEFAULT_ARGS}
passed to the CMake invocation of the YCM boostrap: without that, the-G<Generator>
command was considered as part of the last variable set in _YCM_EP_CMAKE_CACHE_DEFAULT_ARGS, and effectively ignored.|
as list separtor in the-DCMAKE_PREFIX_PATH:PATH=
argument of the CMake invocation to create problems, once fixed the CMake configuration was failing for this reason. As YCM bootstrap does not need to find anything usingCMAKE_PREFIX_PATH
, the easiest solution is just to remove it from the invocation command.