Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating self-signed TLS certificates #6

Closed
roblillack opened this issue Mar 2, 2017 · 1 comment
Closed

Add support for generating self-signed TLS certificates #6

roblillack opened this issue Mar 2, 2017 · 1 comment
Assignees

Comments

@roblillack
Copy link
Owner

This makes sense in a production environment where the connection between the backend (Mars) and the frontend (ie. AWS Application Load Balancer) server shall be encrypted and it does not make sense to manually update certificates all the time.

@roblillack
Copy link
Owner Author

roblillack commented Mar 2, 2017

Implemented this together with dual-stack HTTP support.

The following config options where added:

  • http.dualstack (default: false) to enable dualstack mode (serving HTTP and HTTPS).
  • https.addr (default: ":https") to specify the TLS port to listen on.
  • https.selfsign (default: false) to enable the creation of self-signed certificates on-the-fly.
  • https.organization (default: "ACME Inc.") organization name to add to the certificate.
  • https.domains (default: "127.0.0.1") comma-separated list of names and IP addresses to add to the certificate. Could be "example.com, *.example.com" for example.

Changed config settings:

  • https.enabled (default: false) is the new name for http.ssl (obsolete, but still works)
  • https.certfile (default: "") is the new name for http.sslcert (obsolete, but still works)
  • https.keyfile (default: "") is the new name for http.sslkey (obsolete, but still works)
  • http.port is obsolete and will be removed in the future, please specify a full address string in http.addr and/or https.addr

API changes:

  • mars.Run() does not take any arguments anymore, as this would not make sense in dual-stack mode.

roblillack added a commit that referenced this issue Mar 2, 2017
TheHippo added a commit to TheHippo/mars that referenced this issue Mar 1, 2018
TheHippo added a commit to TheHippo/mars that referenced this issue Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant