Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Transaction.btc/usd #22

Open
JeremyRand opened this issue Mar 23, 2022 · 0 comments · May be fixed by #23
Open

Document Transaction.btc/usd #22

JeremyRand opened this issue Mar 23, 2022 · 0 comments · May be fixed by #23

Comments

@JeremyRand
Copy link
Contributor

At a quick glance at the Transaction class, it is not immediately obvious whether the btc and usd attributes include or exclude the fee. It would be nice if there were a comment for this class's definition that clarifies this aspect of the API. (Based on looking at the BitcoindParser class implementation, I am reasonably confident that it excludes the fee.)

JeremyRand pushed a commit to JeremyRand/bitcoin-taxes that referenced this issue Apr 13, 2023
@JeremyRand JeremyRand linked a pull request Apr 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant