Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hygienics issue in derive macro #21

Closed
CGamesPlay opened this issue Jul 19, 2022 · 1 comment
Closed

Hygienics issue in derive macro #21

CGamesPlay opened this issue Jul 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@CGamesPlay
Copy link

Hello, I'm getting started on integrating rkyv into my crate and I ran into a small splinter. I have a custom Result type alias which causes errors when deriving CheckBytes. The fix is to use the fully-qualified name ::std::result::Result everywhere in the macro.

A test case could be added that includes no_implicit_prelude to detect any other hygienics issues of this sort.

@djkoloski djkoloski added the enhancement New feature or request label Jul 19, 2022
@djkoloski
Copy link
Collaborator

Fixed by f2c4eff. I tried using no_implicit_prelude but it ended up causing more noise than signal by complaining about uses of Ok, Err, and Sized. If the opportunity comes up for a full pass on the derive macro, I'll take a look at using it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants