Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): rename --license-key-file to --license-key-path #18838

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The new argument introduced in #18768 was mistakenly named --license-key-file, while the env var and internal names are license_key_path. This PR unifies the naming.

See also:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Oct 10, 2024

@BugenZhao BugenZhao requested review from fuyufjh and arkbriar October 10, 2024 09:09
@BugenZhao BugenZhao changed the base branch from bz/license-key-not-compatible-with-path to graphite-base/18838 October 10, 2024 09:24
Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member Author

BugenZhao commented Oct 11, 2024

Merge activity

@BugenZhao BugenZhao force-pushed the bz/watch-license-key-arg-name branch from 3abf4f5 to ae49e44 Compare October 11, 2024 06:04
@BugenZhao BugenZhao requested a review from a team as a code owner October 11, 2024 06:04
@BugenZhao BugenZhao requested review from stdrc and removed request for a team October 11, 2024 06:04
@BugenZhao BugenZhao changed the base branch from graphite-base/18838 to main October 11, 2024 06:04
@BugenZhao BugenZhao enabled auto-merge October 11, 2024 06:05
@BugenZhao BugenZhao added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit d6dc650 Oct 11, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/watch-license-key-arg-name branch October 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants