Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): reject directly setting license key when it's managed by watching a file #18823

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

When --license-key-path is specified, license key from initial system parameters or future ALTERing can easily get overwritten. In this PR, we reject such cases to avoid confusion.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@BugenZhao BugenZhao added this pull request to the merge queue Oct 10, 2024
@BugenZhao BugenZhao removed this pull request from the merge queue due to a manual request Oct 10, 2024
Copy link
Member Author

BugenZhao commented Oct 10, 2024

Copy link
Member Author

BugenZhao commented Oct 10, 2024

Merge activity

  • Oct 10, 5:25 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).
  • Oct 11, 12:47 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 11, 12:47 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@BugenZhao BugenZhao added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit b01906e Oct 11, 2024
32 of 33 checks passed
@BugenZhao BugenZhao deleted the bz/license-key-not-compatible-with-path branch October 11, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants