Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg-cdc): add validation for slot name of pg cdc source #17949

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix(pg-cdc): add validation for slot name of pg cdc source #17949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aed7ef
chore(pg-cdc): add validation for slot name of pg cdc source
KeXiangWang Aug 6, 2024
848fdaa
Update src/frontend/src/handler/create_source.rs
KeXiangWang Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/frontend/src/handler/create_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,12 +1156,30 @@ pub fn validate_compatibility(
}

if connector == POSTGRES_CDC_CONNECTOR || connector == CITUS_CDC_CONNECTOR {
if !props.contains_key("slot.name") {
// Build a random slot name with UUID
// e.g. "rw_cdc_f9a3567e6dd54bf5900444c8b1c03815"
let uuid = uuid::Uuid::new_v4().to_string().replace('-', "");
props.insert("slot.name".into(), format!("rw_cdc_{}", uuid));
match props.get("slot.name") {
None => {
// Build a random slot name with UUID
// e.g. "rw_cdc_f9a3567e6dd54bf5900444c8b1c03815"
let uuid = uuid::Uuid::new_v4();
props.insert("slot.name".into(), format!("rw_cdc_{}", uuid.simple()));
}
Some(slot_name) => {
// please refer to
// - https://github.com/debezium/debezium/blob/97956ce25b7612e3413d363658661896b7d2e0a2/debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java#L1179
// - https://doxygen.postgresql.org/slot_8c.html#afac399f07320b9adfd2c599cf822aaa3
if !slot_name
.chars()
.all(|c| c.is_ascii_lowercase() || c.is_ascii_digit() || c == '_')
|| slot_name.len() > 63
{
return Err(RwError::from(ProtocolError(format!(
"Invalid replication slot name: {:?}. Valid replication slot name must contain only digits, lowercase characters and underscores with length <= 63",
slot_name
))));
}
}
}

if !props.contains_key("schema.name") {
// Default schema name is "public"
props.insert("schema.name".into(), "public".into());
Expand Down
Loading