Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg-cdc): add validation for slot name of pg cdc source #17949

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Aug 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

the slot.name of postgres cdc source should follow this rule:

Valid replication slot name must contain only digits, lowercase characters and underscores with length <= 63

@KeXiangWang KeXiangWang requested review from xiangjinwu, fuyufjh and StrikeW and removed request for xiangjinwu August 6, 2024 18:11
@KeXiangWang KeXiangWang changed the title chore(pg-cdc): add validation for slot name of pg cdc source fix(pg-cdc): add validation for slot name of pg cdc source Aug 7, 2024
@github-actions github-actions bot added the type/fix Bug fix label Aug 7, 2024
src/frontend/src/handler/create_source.rs Outdated Show resolved Hide resolved
@KeXiangWang KeXiangWang enabled auto-merge August 7, 2024 03:07
@KeXiangWang KeXiangWang added this pull request to the merge queue Aug 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
@KeXiangWang KeXiangWang added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 50294de Aug 7, 2024
29 of 30 checks passed
@KeXiangWang KeXiangWang deleted the wkx/add-validation-for-slot-name branch August 7, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants