Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(hashkey): refine the memory reserving for SerializedKey #9305

Closed
st1page opened this issue Apr 20, 2023 · 2 comments · Fixed by #9556
Closed

perf(hashkey): refine the memory reserving for SerializedKey #9305

st1page opened this issue Apr 20, 2023 · 2 comments · Fixed by #9556
Assignees
Milestone

Comments

@st1page
Copy link
Contributor

st1page commented Apr 20, 2023

I think it is not good enough, we can get each row's value encoding size like #8924. And after that, we can avoid any grow of the vec

Originally posted by @st1page in #8885 (comment)

@kwannoel
Copy link
Contributor

More info from @st1page offline:

In nexmark q17, it works well because all the string have the same length and they comes from date, but we need to optimize it in more case :h

@kwannoel
Copy link
Contributor

kwannoel commented Apr 28, 2023

Additionally, fixed size key should not have estimation, it does not use value encoding. Currently implementation couples both serialized and fixed size key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants