Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bushy tree join ordering #8139

Closed
chenzl25 opened this issue Feb 23, 2023 · 7 comments
Closed

feat: Bushy tree join ordering #8139

chenzl25 opened this issue Feb 23, 2023 · 7 comments
Assignees
@KveinAxel
Labels
type/feature
Milestone
release-1.0

Comments

@chenzl25
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Implement bushy tree join ordering to minimize the height of the join tree based on the RFC risingwavelabs/rfcs#23.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@github-actions github-actions bot added this to the release-0.1.18 milestone Feb 23, 2023
@lmatz
Copy link
Contributor

lmatz commented Feb 23, 2023

I suppose it will be optional by turning on/off session variables, and thus will not be in conflict with query hints(in the future) for join ordering?

@chenzl25
Copy link
Contributor Author

I suppose it will be optional by turning on/off session variables, and thus will not be in conflict with query hints(in the future) for join ordering?

Yes.

@liurenjie1024
Copy link
Contributor

Will we support it in batch query?

@liurenjie1024 liurenjie1024 changed the title Bushy tree join ordering Tracking: Bushy tree join ordering Feb 23, 2023
@liurenjie1024 liurenjie1024 changed the title Tracking: Bushy tree join ordering feat: Bushy tree join ordering Feb 23, 2023
@chenzl25
Copy link
Contributor Author

Will we support it in batch query?

This optimization can work for batch as well, but it might result in more memory consumption for the distributed batch queries.

@kwannoel kwannoel mentioned this issue Feb 24, 2023
Open
@kwannoel
Copy link
Contributor

kwannoel commented Feb 24, 2023 •
edited
Loading

Recommend this for testing: #8173

@fuyufjh fuyufjh modified the milestones: release-0.18, release-0.19 Mar 22, 2023
@chenzl25
Copy link
Contributor Author

Add a bench. https://www.notion.so/risingwave-labs/Join-Ordering-Bench-fe6478688e0348249c1f12dcbd599a30

@chenzl25 chenzl25 modified the milestones: release-0.19, release-0.20 May 12, 2023
@chenzl25
Copy link
Contributor Author

chenzl25 commented Aug 8, 2023 •
edited
Loading

Related PR
#9394
#8316

@chenzl25 chenzl25 closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KveinAxel KveinAxel

Labels
type/feature
Projects
None yet
Milestone
release-1.0
Development

No branches or pull requests
6 participants
@liurenjie1024 @lmatz @chenzl25 @fuyufjh @KveinAxel @kwannoel