Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: meta does not stop as expected #7654

Closed
Tracked by #6640
tabVersion opened this issue Feb 1, 2023 · 4 comments · Fixed by #7661
Closed
Tracked by #6640

bug: meta does not stop as expected #7654

tabVersion opened this issue Feb 1, 2023 · 4 comments · Fixed by #7661
Assignees
@shanicky
Labels
type/bug Something isn't working
Milestone
release-0.1.17

Comments

@tabVersion
Copy link
Contributor

Describe the bug

image

cargo make playground

after pressing ctrl_c, meta continues printing log

To Reproduce

No response

Expected behavior

No response

Additional context

No response
@tabVersion tabVersion added the type/bug Something isn't working label Feb 1, 2023
@github-actions github-actions bot added this to the release-0.1.17 milestone Feb 1, 2023
@neverchanje
Copy link
Contributor

Do you know why madsim cannot detect this type of bug? @wangrunji0408

@wangrunji0408
Copy link
Contributor

Do you know why madsim cannot detect this type of bug? @wangrunji0408

Madsim doesn't simulate Ctrl+C. Instead, it kills nodes by dropping tasks.

@yezizp2012
Copy link
Member

I'm not sure if it's because the service discovery in the meta client don't support graceful shutdown. Cc @shanicky please help to confirm and fix it if so. 🙏

@wangrunji0408
Copy link
Contributor

Looks like we need to add graceful shutdown to the simulation test. 👀

@yezizp2012 yezizp2012 mentioned this issue Feb 2, 2023
Merged
5 tasks
@mergify mergify bot closed this as completed in #7661 Feb 2, 2023
@yezizp2012 yezizp2012 reopened this Feb 2, 2023
@lmatz lmatz mentioned this issue Feb 2, 2023
Open
65 tasks
@wangrunji0408 wangrunji0408 mentioned this issue Feb 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanicky shanicky

Labels
type/bug Something isn't working
Projects
None yet
Milestone
release-0.1.17
5 participants
@shanicky @neverchanje @tabVersion @yezizp2012 @wangrunji0408