-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-timing not shown on Windows? #262
Comments
Can you test with the Kreya example project (this one: https://github.com/riok/Kreya/tree/master/example-project)? |
With the example-project the Server-Timings section is shown on windows as it should be. Strange.
Our own project, where it is only shown on linux (even though as I wrote it is visible in the header-tab) sends this:
Look valid to me? |
Yes it looks valid. If I try that header, it also works for me... Could you show a screenshot? Maybe we missed something else... What type of gRPC operation is it? Could you also try the |
Thanks for the quick replies, I'll try to reproduce this |
I was finally able to reproduce and fix this. The problem was that we parsed the duration based on the user culture. In this case, the culture was set to something that has a period as the thousand separator, which caused the number to be parsed incorrectly. The resulting duration was too large, which is why it wasn't being displayed. The user culture should obviously not be respected in this case. The bugfix will be included in the next release |
I have been bitten by that very thing as well. Great you found it. |
Describe the bug
I have implemented a gRPC service returning a server-timing header as described here: https://kreya.app/blog/kreya-1.12-whats-new/#operation-and-server-timing-
On Kreya 1.15 on linux Kreya shows a Server Timing section in the Timing tab, with the fields set in the header (as shown in the link above).
But on Kreya 1.15 on Windows this is not shown. Both on Linux and on Windows you can see the server-timing header under the "Header" tab for the call.
To Reproduce
See above.
Expected behavior
The Server Timing info to be shown in Windows version also.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (if possible, copy the information from the error dialog or the About menu):
The text was updated successfully, but these errors were encountered: