Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-timing not shown on Windows? #262

Open
tweidema opened this issue Nov 18, 2024 · 8 comments
Open

Server-timing not shown on Windows? #262

tweidema opened this issue Nov 18, 2024 · 8 comments
Labels
bug Something isn't working status:waiting-for-release Implemented, waiting for next stable release

Comments

@tweidema
Copy link

Describe the bug
I have implemented a gRPC service returning a server-timing header as described here: https://kreya.app/blog/kreya-1.12-whats-new/#operation-and-server-timing-
On Kreya 1.15 on linux Kreya shows a Server Timing section in the Timing tab, with the fields set in the header (as shown in the link above).
But on Kreya 1.15 on Windows this is not shown. Both on Linux and on Windows you can see the server-timing header under the "Header" tab for the call.

To Reproduce
See above.

Expected behavior
The Server Timing info to be shown in Windows version also.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (if possible, copy the information from the error dialog or the About menu):

  • OS: Windows 11 PRO 23H2
  • Kreya Version 1.15.0
@tweidema tweidema added the bug Something isn't working label Nov 18, 2024
@CommonGuy
Copy link
Contributor

Can you test with the Kreya example project (this one: https://github.com/riok/Kreya/tree/master/example-project)?

I'm on Windows too and it works for me:
grafik

@CommonGuy CommonGuy added the status:needs-info To investigate this, more information is needed label Nov 19, 2024
@tweidema
Copy link
Author

With the example-project the Server-Timings section is shown on windows as it should be. Strange.
The example-project sends this server-timing header:

db;dur=53, app;dur=417.2, cache;dur=123.2, total;dur=593.4

Our own project, where it is only shown on linux (even though as I wrote it is visible in the header-tab) sends this:

gRPC;dur=27.83489227294922

Look valid to me?

@CommonGuy
Copy link
Contributor

CommonGuy commented Nov 19, 2024

Yes it looks valid. If I try that header, it also works for me... Could you show a screenshot? Maybe we missed something else... What type of gRPC operation is it?

Could you also try the SayHello gRPC method of the example project? Maybe it is specific to gRPC...

@tweidema
Copy link
Author

It's a simple unary gRPC call, no streaming. I will try to get the Windows-user make screenshots when she comes in, but here is what it looks like on linux (where it works fine):
linux_header
linux_timing

@tweidema
Copy link
Author

And this is what it looks like on Windows 11 PRO 23H2
T3
T5

@CommonGuy
Copy link
Contributor

Thanks for the quick replies, I'll try to reproduce this

@CommonGuy CommonGuy added status:waiting-for-release Implemented, waiting for next stable release and removed status:needs-info To investigate this, more information is needed labels Nov 24, 2024
@CommonGuy
Copy link
Contributor

I was finally able to reproduce and fix this. The problem was that we parsed the duration based on the user culture. In this case, the culture was set to something that has a period as the thousand separator, which caused the number to be parsed incorrectly. The resulting duration was too large, which is why it wasn't being displayed.

The user culture should obviously not be respected in this case. The bugfix will be included in the next release

@tweidema
Copy link
Author

I have been bitten by that very thing as well. Great you found it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:waiting-for-release Implemented, waiting for next stable release
Projects
None yet
Development

No branches or pull requests

2 participants