Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit expression nesting level to avoid stack overflows #866

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Limit expression nesting level to avoid stack overflows #866

merged 1 commit into from
Sep 28, 2023

Conversation

djc
Copy link
Collaborator

@djc djc commented Sep 28, 2023

This is triggered by the fuzzer, see also https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62759.

@Kijewski
Copy link
Collaborator

Kijewski commented Sep 28, 2023

Wouldn't the same be needed for Nodes, too?

{%if true%}{%if true%}{%if true%}{%if true%}{%if true%}{%if true%}{%if true%}{%if true%}...

@djc
Copy link
Collaborator Author

djc commented Sep 28, 2023

Probably? Was going to wait until the fuzzer complains.

askama_parser/src/expr.rs Outdated Show resolved Hide resolved
@djc djc merged commit c853049 into main Sep 28, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nested branch September 28, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants