-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make askama_shared::parser
module public
#760
Comments
I was looking at the docs from the last published version. My use case is to be able to write my own proc-macro with |
What different needs? Smaller in what dimension? |
Different needs in the storage (compile-time generated hashmap which updates templates in case they're updated) and smaller in term of deps and code ( |
Would you be interested in contributing your synless derive code here? I would be open to entertaining it (though I would like to understand this plan in more detail). As for the compile-time stuff, I've been contemplating an API that lets you run codegen asynchronously (for example, I have a bunch of code that regenerates only in an integration test so it fails in CI if the generated code is out of date). If this would address your issues, we could work on it in this repo. |
Further thoughts: is this driven by rustdoc needs? Is there a discussion in Zulip or in another repo somewhere that I could look at about the concerns? |
Sure. The plan is basically to be able to get rid of the proc-macros by settting up the parser "by hand" (and of course, if possible at compile-time). And it's not a rustdoc need but a personal one. So no discussion that can be seen anywhere. |
Sounds like a good plan, want to submit a PR with what you've got so far? |
Need to clean up things a bit. A bit under water currently but I'll try to send a PR as soon as possible. |
No hurry! |
#834 extracts a parser crate. |
Is there any reason for this module to be private? Making it public would allow to have access to the parser directly.
The text was updated successfully, but these errors were encountered: