Fix the generated password not being idempotent in the ClickHouse provisioner #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspersjo
approved these changes
Dec 12, 2024
| // When creating the user, the password assignment is not idempotent (if there are two concurrent invocations, we don't know which password was used). | ||
| // By adding the password separately, we ensure all passwords will work. | ||
| // NOTE: Requires ClickHouse 24.9 or later. | ||
| _, err = p.ch.ExecContext(ctx, fmt.Sprintf("ALTER USER %s ADD IDENTIFIED WITH sha256_password BY ?", user), password) |
There was a problem hiding this comment.
Seems risky, in a rare case of id collision, would it end up giving an existing project access to previously created DB ? However, in case of id collision we would have even bigger troubles..
Usually, locking on table name would be less prone to errors...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing the
clickhouse.yamlfile with keystroke-by-keystroke editing, provisioning calls can be rapidly cancelled and retried. This surfaced an idempotency issue where callingCREATE USER IF NOT EXISTSdid not use the generated random password, causing the generated DSN to be invalid. This PR fixes the problem by leveraging ClickHouse's support for adding multiple passwords to one user.