Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor canvas and component specs #5978

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Oct 25, 2024

  • Removes support for data: properties in the component YAML
  • Changes the ResolveComponent RPC to only resolve templating in the renderer properties
  • Removes the already deprecated components/{name}/data endpoint
  • As a small affordance for better error messages, if a component's renderer properties contains a metrics_view key, it add it to the component's refs
  • (New) Removed gap and column from the canvas YAML
  • (New) Added max_width to the canvas YAML
  • (New) Added theme to the canvas YAML with the same behavior as in the explore YAML
  • (New) Removed exceptional handling for vega_lite, moved its validation to component-template-v1.json

Closes #5892

@begelundmuller begelundmuller marked this pull request as draft October 28, 2024 10:30
@begelundmuller
Copy link
Contributor Author

Marking this PR as draft pending finalization of the new semantics for canvas dashboards. @djbarnwal will follow up.

@begelundmuller begelundmuller self-assigned this Oct 28, 2024
@begelundmuller begelundmuller changed the title Remove data resolvers from components Refactor canvas and component specs Dec 4, 2024
@begelundmuller begelundmuller marked this pull request as ready for review December 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime: Remove data resolvers for components
1 participant