Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through original entity + PHPStan Cleanup #60

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

dereuromark
Copy link
Contributor

With this the following works without having to fork/copy the behavior on project level:

            'set' => [
                'ancestor_id' => function (Order $order, Order $original) {
                    return $original->id;
                },
            ],

@ADmad
Copy link
Collaborator

ADmad commented Aug 7, 2024

I don't see any change except for the phpstan cleanups. Please at least make a separate commit for the change you are proposing to make reviewing easier.

@dereuromark
Copy link
Contributor Author

dereuromark commented Aug 7, 2024

Indeed, those are only PHPStan so far.

@dereuromark
Copy link
Contributor Author

I forget the other changes and would add them on top or as separate PR.

Copy link
Collaborator

@ADmad ADmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing seems find except for the argument order I commented about. Also please add some tests.

src/Model/Behavior/DuplicatableBehavior.php Outdated Show resolved Hide resolved
@ADmad ADmad merged commit ac20128 into riesenia:master Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants