diff --git a/examples/java/pom.xml b/examples/java/pom.xml index 12a114fe927d..857373a1b587 100644 --- a/examples/java/pom.xml +++ b/examples/java/pom.xml @@ -283,74 +283,6 @@ maven-source-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - Apache Beam Examples - Apache Beam Examples - - org.apache.beam.examples - -exclude org.apache.beam.sdk.runners.worker:org.apache.beam.sdk.runners.dataflow:org.apache.beam.sdk.util ${beam.javadoc_opts} - false - true - ]]> - - - - - https://cloud.google.com/dataflow/java-sdk/JavaDoc/ - ${basedir}/../../sdks/java/javadoc/dataflow-sdk-docs - - - - https://developers.google.com/api-client-library/java/google-api-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/apiclient-docs - - - http://avro.apache.org/docs/${avro.version}/api/java/ - ${basedir}/../../sdks/java/javadoc/avro-docs - - - https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/ - ${basedir}/../../sdks/java/javadoc/bq-docs - - - https://cloud.google.com/datastore/docs/apis/javadoc/ - ${basedir}/../../sdks/java/javadoc/datastore-docs - - - http://docs.guava-libraries.googlecode.com/git-history/release18/javadoc/ - ${basedir}/../../sdks/java/javadoc/guava-docs - - - http://fasterxml.github.io/jackson-annotations/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-annotations-docs - - - http://fasterxml.github.io/jackson-databind/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-databind-docs - - - http://www.joda.org/joda-time/apidocs - ${basedir}/../../sdks/java/javadoc/joda-docs - - - https://developers.google.com/api-client-library/java/google-oauth-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/oauth-docs - - - - - - - jar - - package - - - - org.apache.maven.plugins maven-shade-plugin diff --git a/examples/java8/pom.xml b/examples/java8/pom.xml index 18257d9b3c83..0a5dcb0934ce 100644 --- a/examples/java8/pom.xml +++ b/examples/java8/pom.xml @@ -119,14 +119,6 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:missing - - - maven-compiler-plugin diff --git a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/GameStats.java b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/GameStats.java index 5ebf89286481..2b5255faeafb 100644 --- a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/GameStats.java +++ b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/GameStats.java @@ -100,7 +100,8 @@ public class GameStats extends LeaderBoard { /** * Filter out all but those users with a high clickrate, which we will consider as 'spammy' uesrs. * We do this by finding the mean total score per user, then using that information as a side - * input to filter out all but those user scores that are > (mean * SCORE_WEIGHT) + * input to filter out all but those user scores that are larger than + * {@code (mean * SCORE_WEIGHT)}. */ // [START DocInclude_AbuseDetect] public static class CalculateSpammyUsers diff --git a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/LeaderBoard.java b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/LeaderBoard.java index d5e3345c6f9a..0a3dfb3f71cf 100644 --- a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/LeaderBoard.java +++ b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/LeaderBoard.java @@ -73,7 +73,7 @@ * results, e.g. for 'team prizes'. We're now outputting window results as they're * calculated, giving us much lower latency than with the previous batch examples. * - *

Run {@link injector.Injector} to generate pubsub data for this pipeline. The Injector + *

Run {@code injector.Injector} to generate pubsub data for this pipeline. The Injector * documentation provides more detail on how to do this. * *

To execute this pipeline using the Dataflow service, specify the pipeline configuration diff --git a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/UserScore.java b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/UserScore.java index 32c939f32513..f4dca324f33e 100644 --- a/examples/java8/src/main/java/org/apache/beam/examples/complete/game/UserScore.java +++ b/examples/java8/src/main/java/org/apache/beam/examples/complete/game/UserScore.java @@ -68,7 +68,7 @@ * where the BigQuery dataset you specify must already exist. * *

Optionally include the --input argument to specify a batch input file. - * See the --input default value for example batch data file, or use {@link injector.Injector} to + * See the --input default value for example batch data file, or use {@code injector.Injector} to * generate your own batch data. */ public class UserScore { diff --git a/pom.xml b/pom.xml index 14c38fdee060..77e87bafa9f5 100644 --- a/pom.xml +++ b/pom.xml @@ -160,6 +160,9 @@ org.apache.maven.plugins maven-javadoc-plugin + + ${beam.javadoc_opts} + javadoc @@ -212,6 +215,11 @@ org.apache.rat apache-rat-plugin + + + org.apache.maven.plugins + maven-javadoc-plugin + @@ -222,9 +230,10 @@ [1.8,) - -Xdoclint:-missing + -Xdoclint:all -Xdoclint:-missing + java7-packageinfo diff --git a/runners/core-java/pom.xml b/runners/core-java/pom.xml index fa646601058d..3d8a84b82a66 100644 --- a/runners/core-java/pom.xml +++ b/runners/core-java/pom.xml @@ -63,29 +63,6 @@ maven-source-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - Beam Runners Core utilities ${project.version} API - Beam Runners Core utilities for Java, version ${project.version} - ../javadoc/overview.html - - org.apache.beam.runners.core - false - true - ]]> - - - - - jar - - package - - - - org.apache.maven.plugins maven-shade-plugin diff --git a/runners/direct-java/pom.xml b/runners/direct-java/pom.xml index b781c6e55802..64e9b5a458f3 100644 --- a/runners/direct-java/pom.xml +++ b/runners/direct-java/pom.xml @@ -92,67 +92,6 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - - Apache Beam Direct Runner ${project.version} - Apache Beam Direct Runner, version ${project.version} - - org.apache.beam.runners.direct - false - true - ]]> - - - - https://developers.google.com/api-client-library/java/google-api-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/apiclient-docs - - - http://avro.apache.org/docs/${avro.version}/api/java/ - ${basedir}/../../sdks/java/javadoc/avro-docs - - - https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/ - ${basedir}/../../sdks/java/javadoc/bq-docs - - - https://cloud.google.com/datastore/docs/apis/javadoc/ - ${basedir}/../../sdks/java/javadoc/datastore-docs - - - http://docs.guava-libraries.googlecode.com/git-history/release19/javadoc/ - ${basedir}/../../sdks/java/javadoc/guava-docs - - - http://hamcrest.org/JavaHamcrest/javadoc/1.3/ - ${basedir}/../../sdks/java/javadoc/hamcrest-docs - - - http://fasterxml.github.io/jackson-annotations/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-annotations-docs - - - http://fasterxml.github.io/jackson-databind/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-databind-docs - - - http://www.joda.org/joda-time/apidocs - ${basedir}/../../sdks/java/javadoc/joda-docs - - - http://junit.sourceforge.net/javadoc/ - ${basedir}/../../sdks/java/javadoc/junit-docs - - - https://developers.google.com/api-client-library/java/google-oauth-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/oauth-docs - - - - - org.apache.maven.plugins maven-shade-plugin diff --git a/runners/flink/examples/pom.xml b/runners/flink/examples/pom.xml index 409d77be3c11..051ec2d22bbc 100644 --- a/runners/flink/examples/pom.xml +++ b/runners/flink/examples/pom.xml @@ -109,14 +109,6 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:missing - - - org.codehaus.mojo exec-maven-plugin diff --git a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/AutoComplete.java b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/AutoComplete.java index 97ba232b1703..1e0c3acdc48d 100644 --- a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/AutoComplete.java +++ b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/AutoComplete.java @@ -53,11 +53,9 @@ /** * To run the example, first open a socket on a terminal by executing the command: - *

  • - *
  • - * nc -lk 9999 - *
  • - * + *
      + *
    • nc -lk 9999 + *
    * and then launch the example. Now whatever you type in the terminal is going to be * the input to the program. * */ diff --git a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/JoinExamples.java b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/JoinExamples.java index 96638aab1db6..8fefc9f2a529 100644 --- a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/JoinExamples.java +++ b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/JoinExamples.java @@ -39,14 +39,10 @@ /** * To run the example, first open two sockets on two terminals by executing the commands: - *
  • - *
  • - * nc -lk 9999, and - *
  • - *
  • - * nc -lk 9998 - *
  • - * + *
      + *
    • nc -lk 9999, and + *
    • nc -lk 9998 + *
    * and then launch the example. Now whatever you type in the terminal is going to be * the input to the program. * */ diff --git a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/KafkaIOExamples.java b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/KafkaIOExamples.java index f0bf188e3228..3c8a89bcf2f9 100644 --- a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/KafkaIOExamples.java +++ b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/KafkaIOExamples.java @@ -170,7 +170,7 @@ public static void main(String[] args) { /** * Serialiation/Deserialiation schema for Avro types. - * @param + * @param the type being encoded */ static class AvroSerializationDeserializationSchema implements SerializationSchema, DeserializationSchema { diff --git a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/WindowedWordCount.java b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/WindowedWordCount.java index 0e250b868b72..2246bddaed83 100644 --- a/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/WindowedWordCount.java +++ b/runners/flink/examples/src/main/java/org/apache/beam/runners/flink/examples/streaming/WindowedWordCount.java @@ -42,11 +42,9 @@ /** * To run the example, first open a socket on a terminal by executing the command: - *
  • - *
  • - * nc -lk 9999 - *
  • - * + *
      + *
    • nc -lk 9999 + *
    * and then launch the example. Now whatever you type in the terminal is going to be * the input to the program. * */ diff --git a/runners/flink/runner/pom.xml b/runners/flink/runner/pom.xml index 928889e9751b..972931674a72 100644 --- a/runners/flink/runner/pom.xml +++ b/runners/flink/runner/pom.xml @@ -242,14 +242,6 @@
    - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:missing - - - org.apache.maven.plugins diff --git a/runners/google-cloud-dataflow-java/pom.xml b/runners/google-cloud-dataflow-java/pom.xml index d8f1b825c166..0a2c9f6a8873 100644 --- a/runners/google-cloud-dataflow-java/pom.xml +++ b/runners/google-cloud-dataflow-java/pom.xml @@ -83,76 +83,6 @@ maven-source-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - Google Cloud Dataflow Java Runner ${project.version} - Google Cloud Dataflow Runner for Java, version ${project.version} - - org.apache.beam.runners.dataflow - -exclude org.apache.beam.sdk.runners.dataflow.internal:org.apache.beam.sdk.runners.dataflow.testing:org.apache.beam.sdk.runners.dataflow.util ${beam.javadoc_opts} - false - true - ]]> - - - - https://developers.google.com/api-client-library/java/google-api-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/apiclient-docs - - - http://avro.apache.org/docs/${avro.version}/api/java/ - ${basedir}/../../sdks/java/javadoc/avro-docs - - - https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/ - ${basedir}/../../sdks/java/javadoc/bq-docs - - - https://cloud.google.com/datastore/docs/apis/javadoc/ - ${basedir}/../../sdks/java/javadoc/datastore-docs - - - http://docs.guava-libraries.googlecode.com/git-history/release19/javadoc/ - ${basedir}/../../sdks/java/javadoc/guava-docs - - - http://hamcrest.org/JavaHamcrest/javadoc/1.3/ - ${basedir}/../../sdks/java/javadoc/hamcrest-docs - - - http://fasterxml.github.io/jackson-annotations/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-annotations-docs - - - http://fasterxml.github.io/jackson-databind/javadoc/2.7/ - ${basedir}/../../sdks/java/javadoc/jackson-databind-docs - - - http://www.joda.org/joda-time/apidocs - ${basedir}/../../sdks/java/javadoc/joda-docs - - - http://junit.sourceforge.net/javadoc/ - ${basedir}/../../sdks/java/javadoc/junit-docs - - - https://developers.google.com/api-client-library/java/google-oauth-java-client/reference/1.20.0/ - ${basedir}/../../sdks/java/javadoc/oauth-docs - - - - - - - jar - - package - - - - org.apache.maven.plugins maven-shade-plugin diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java index 27006a48fdba..a2b632fcc7a2 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java @@ -199,7 +199,6 @@ public State waitUntilFinish(Duration duration) { * thread is interrupted. * @throws IOException If there is a persistent problem getting job * information. - * @throws InterruptedException */ @Nullable @VisibleForTesting diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/IsmFormat.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/IsmFormat.java index 903e7b43c220..2f83ffda276a 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/IsmFormat.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/internal/IsmFormat.java @@ -167,11 +167,12 @@ public byte[] getMetadata() { } } - /** A {@link Coder} for {@link IsmRecord}s. + /** + * A {@link Coder} for {@link IsmRecord}s. * *

    Note that this coder standalone will not produce an Ism file. This coder can be used * to materialize a {@link PCollection} of {@link IsmRecord}s. Only when this coder - * is combined with an {@link IsmSink} will one produce an Ism file. + * is combined with an {@code IsmSink} will one produce an Ism file. * *

    The {@link IsmRecord} encoded format is: *

      diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java index a6afccdccb44..efb6d2b224f0 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/MonitoringUtil.java @@ -149,7 +149,6 @@ public int compare(JobMessage o1, JobMessage o2) { * @param startTimestampMs Return only those messages with a * timestamp greater than this value. * @return collection of messages - * @throws IOException */ public ArrayList getJobMessages( String jobId, long startTimestampMs) throws IOException { diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/RandomAccessData.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/RandomAccessData.java index 84c53eaa5f5f..11eec19bdd08 100644 --- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/RandomAccessData.java +++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/RandomAccessData.java @@ -121,7 +121,7 @@ protected long getEncodedElementByteSize(RandomAccessData value, Coder.Context c * A {@link Comparator} that compares two byte arrays lexicographically. It compares * values as a list of unsigned bytes. The first pair of values that follow any common prefix, * or when one array is a prefix of the other, treats the shorter array as the lesser. - * For example, [] < [0x01] < [0x01, 0x7F] < [0x01, 0x80] < [0x02] < POSITIVE INFINITY. + * For example, {@code [] < [0x01] < [0x01, 0x7F] < [0x01, 0x80] < [0x02] < POSITIVE INFINITY}. * *

      Note that a token type of positive infinity is supported and is greater than * all other {@link RandomAccessData}. diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml index 0edafe84d9d7..a3ca296f57cc 100644 --- a/runners/spark/pom.xml +++ b/runners/spark/pom.xml @@ -413,10 +413,6 @@ org.apache.maven.plugins maven-source-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - org.apache.maven.plugins maven-shade-plugin diff --git a/sdks/java/core/pom.xml b/sdks/java/core/pom.xml index 40a511c6c061..7d4d9abb33f6 100644 --- a/sdks/java/core/pom.xml +++ b/sdks/java/core/pom.xml @@ -42,71 +42,6 @@ - - org.apache.maven.plugins - maven-javadoc-plugin - - Apache Beam SDK ${project.version} API - Apache Beam SDK for Java, version ${project.version} - ../javadoc/overview.html - - org.apache.beam.sdk - -exclude - org.apache.beam.sdk.runners.worker:org.apache.beam.sdk.runners.dataflow:org.apache.beam.sdk.util:org.apache.beam.sdk.runners.inprocess - ${beam.javadoc_opts} - false - true - ]]> - - - - https://developers.google.com/api-client-library/java/google-api-java-client/reference/1.20.0/ - ${basedir}/../javadoc/apiclient-docs - - - http://avro.apache.org/docs/${avro.version}/api/java/ - ${basedir}/../javadoc/avro-docs - - - https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/ - ${basedir}/../javadoc/bq-docs - - - https://cloud.google.com/datastore/docs/apis/javadoc/ - ${basedir}/../javadoc/datastore-docs - - - http://docs.guava-libraries.googlecode.com/git-history/release19/javadoc/ - ${basedir}/../javadoc/guava-docs - - - http://hamcrest.org/JavaHamcrest/javadoc/1.3/ - ${basedir}/../javadoc/hamcrest-docs - - - http://fasterxml.github.io/jackson-annotations/javadoc/2.7/ - ${basedir}/../javadoc/jackson-annotations-docs - - - http://fasterxml.github.io/jackson-databind/javadoc/2.7/ - ${basedir}/../javadoc/jackson-databind-docs - - - http://www.joda.org/joda-time/apidocs - ${basedir}/../javadoc/joda-docs - - - http://junit.sourceforge.net/javadoc/ - ${basedir}/../javadoc/junit-docs - - - https://developers.google.com/api-client-library/java/google-oauth-java-client/reference/1.20.0/ - ${basedir}/../javadoc/oauth-docs - - - - - org.apache.maven.plugins maven-checkstyle-plugin @@ -170,11 +105,6 @@ maven-source-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - org.apache.maven.plugins maven-shade-plugin diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java index 6deca7f56222..bd0c6558e03a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java @@ -117,10 +117,10 @@ * } * *

      By default, {@link AvroIO.Write} produces output files that are compressed using the - * {@link org.apache.avro.file.DeflateCodec CodecFactory.deflateCodec(6)}. This default can + * {@link org.apache.avro.file.Codec CodecFactory.deflateCodec(6)}. This default can * be changed or overridden using {@link AvroIO.Write#withCodec}. * - *

      Permissions

      + *

      Permissions

      * Permission requirements depend on the {@link PipelineRunner} that is used to execute the * Dataflow job. Please refer to the documentation of corresponding {@link PipelineRunner}s for * more details. diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedSource.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedSource.java index cd4d7db33e68..b3dd1383c912 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedSource.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedSource.java @@ -50,9 +50,6 @@ * *
    * - *

    To use this class for supporting your custom input type, derive your class - * class from it, and override the abstract methods. For an example, see {@link DatastoreIO}. - * * @param Type of records read by the source. */ public abstract class BoundedSource extends Source { @@ -135,7 +132,7 @@ public abstract static class BoundedReader extends Source.Reader { * *

    By default, returns null to indicate that this cannot be estimated. * - *

    Thread safety
    + *

    Thread safety

    * If {@link #splitAtFraction} is implemented, this method can be called concurrently to other * methods (including itself), and it is therefore critical for it to be implemented * in a thread-safe way. @@ -345,7 +342,7 @@ public long getSplitPointsRemaining() { * *

    Returns a {@code BoundedSource} representing the remainder. * - *

    Detailed description
    + *

    Detailed description

    * Assuming the following sequence of calls: *
    {@code
          *   BoundedSource initial = reader.getCurrentSource();
    @@ -371,11 +368,11 @@ public long getSplitPointsRemaining() {
          * corresponding to the given fraction. In this case, the method MUST have no effect
          * (the reader must behave as if the method hadn't been called at all).
          *
    -     * 
    Statefulness
    + *

    Statefulness

    * Since this method (if successful) affects the reader's source, in subsequent invocations * "fraction" should be interpreted relative to the new current source. * - *
    Thread safety and blocking
    + *

    Thread safety and blocking

    * This method will be called concurrently to other methods (however there will not be multiple * concurrent invocations of this method itself), and it is critical for it to be implemented * in a thread-safe way (otherwise data loss is possible). diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/CompressedSource.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/CompressedSource.java index f33b9bd36629..af0c8130a324 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/CompressedSource.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/CompressedSource.java @@ -74,7 +74,6 @@ public class CompressedSource extends FileBasedSource { public interface DecompressingChannelFactory extends Serializable { /** * Given a channel, create a channel that decompresses the content read from the channel. - * @throws IOException */ ReadableByteChannel createDecompressingChannel(ReadableByteChannel channel) throws IOException; @@ -88,7 +87,6 @@ private interface FileNameBasedDecompressingChannelFactory extends DecompressingChannelFactory { /** * Given a channel, create a channel that decompresses the content read from the channel. - * @throws IOException */ ReadableByteChannel createDecompressingChannel(String fileName, ReadableByteChannel channel) throws IOException; diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java index 3d0fe04bb31e..101ff616a3c1 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java @@ -133,7 +133,8 @@ public String getMimeType() { /** * The {@link WritableByteChannelFactory} that is used to wrap the raw data output to the - * underlying channel. The default is to not compress the output using {@link #UNCOMPRESSED}. + * underlying channel. The default is to not compress the output using + * {@link CompressionType#UNCOMPRESSED}. */ protected final WritableByteChannelFactory writableByteChannelFactory; @@ -206,11 +207,6 @@ public String getBaseOutputFilename() { return baseOutputFilename; } - /** - * Perform pipeline-construction-time validation. The default implementation is a no-op. - * Subclasses should override to ensure the sink is valid and can be written to. It is recommended - * to use {@link Preconditions#checkState(boolean)} in the implementation of this method. - */ @Override public void validate(PipelineOptions options) {} @@ -802,7 +798,6 @@ public interface WritableByteChannelFactory extends Serializable { /** * @param channel the {@link WritableByteChannel} to wrap * @return the {@link WritableByteChannel} to be used during output - * @throws IOException */ WritableByteChannel create(WritableByteChannel channel) throws IOException; diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/XmlSource.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/XmlSource.java index aaee75aac6ab..1458f74d0a90 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/XmlSource.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/XmlSource.java @@ -108,7 +108,7 @@ *

    These dependencies have been declared as optional in the sdks/java/core/pom.xml file of * Apache Beam. * - *

    Permissions

    + *

    Permissions

    * Permission requirements depend on the * {@link org.apache.beam.sdk.runners.PipelineRunner PipelineRunner} that is * used to execute the Beam pipeline. Please refer to the documentation of corresponding diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java index 30634411255e..e30f8af911b0 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRange.java @@ -133,7 +133,7 @@ public Boolean overlaps(ByteKeyRange other) { * Specifically, if this range is unsplittable (e.g., because the start and end keys are equal * up to padding by zero bytes), the list returned will only contain the start and end key. * - * @throws IllegalArgumentException if the specified number of splits is < 1 + * @throws IllegalArgumentException if the specified number of splits is less than 1 * @see ByteKeyRange the ByteKeyRange class Javadoc for more information about split semantics. */ public List split(int numSplits) { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java index 4f0280b88f75..188b371c12e1 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ValueProvider.java @@ -133,7 +133,7 @@ public boolean isAccessible() { * construction time. * *

    To enforce this contract, if there is no default, users must only call - * {@link #get()} at execution time (after a call to {@link Pipeline#run}), + * {@link #get()} at execution time (after a call to {@link org.apache.beam.sdk.Pipeline#run}), * which will provide the value of {@code optionsMap}. */ class RuntimeValueProvider implements ValueProvider, Serializable { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Aggregator.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Aggregator.java index 427ecfc29f05..43f53a8d5f94 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Aggregator.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Aggregator.java @@ -29,13 +29,11 @@ * typically from the {@link DoFn} constructor. Elements can be added to the * {@code Aggregator} by calling {@link Aggregator#addValue}. * - *

    Aggregators are visible in the monitoring UI, when the pipeline is run using - * {@link DataflowRunner} along with their current value. - * Aggregators may not become visible until the system begins executing the ParDo transform - * that created them and/or their initial value is changed. + *

    It is runner-dependent whether aggregators are accessible during pipeline execution or only + * after jobs have completed. * *

    Example: - *

     {@code
    + * 
    {@code
      * class MyDoFn extends DoFn {
      *   private Aggregator myAggregator;
      *
    @@ -43,12 +41,12 @@
      *     myAggregator = createAggregator("myAggregator", new Sum.SumIntegerFn());
      *   }
      *
    - *   @ProcessElement
    + *   {@literal @}ProcessElement
      *   public void processElement(ProcessContext c) {
      *     myAggregator.addValue(1);
      *   }
      * }
    - * } 
    + * }
    * * @param the type of input values * @param the type of output values diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java index 1b3e52597f7e..e4e1c50d8671 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java @@ -106,7 +106,7 @@ public static ComposeKeyedCombineFnBuilder composeKeyed() { *

    The same {@link TupleTag} cannot be used in a composition multiple times. * *

    Example: - *

    <{@code
    +   * 
    {@code
        * PCollection globalLatencies = ...;
        *
        * TupleTag maxLatencyTag = new TupleTag();
    @@ -114,7 +114,7 @@ public static ComposeKeyedCombineFnBuilder composeKeyed() {
        *
        * SimpleFunction identityFn =
        *     new SimpleFunction() {
    -   *       @Override
    +   *       {@literal @}Override
        *       public Integer apply(Integer input) {
        *           return input;
        *       }};
    diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
    index 018877fb67a5..2b3962e79422 100644
    --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
    +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
    @@ -76,15 +76,15 @@
      *
      * 

    Example usage: * - *

     {@code
    + * 
    {@code
      * PCollection lines = ... ;
      * PCollection words =
      *     lines.apply(ParDo.of(new DoFn() {
    - *         @ProcessElement
    + *         {@literal @}ProcessElement
      *         public void processElement(ProcessContext c, BoundedWindow window) {
      *
      *         }}));
    - * } 
    + * }
    * * @param the type of the (main) input elements * @param the type of the (main) output elements @@ -436,14 +436,14 @@ public RestrictionTracker restrictionTracker() { * *
    {@code
        * new DoFn, Baz>() {
    -   *   @StateId("my-state-id")
    +   *   {@literal @}StateId("my-state-id")
        *   private final StateSpec> myStateSpec =
        *       StateSpecs.value(new MyStateCoder());
        *
    -   *   @ProcessElement
    +   *   {@literal @}ProcessElement
        *   public void processElement(
        *       ProcessContext c,
    -   *       @StateId("my-state-id") ValueState myState) {
    +   *       {@literal @}StateId("my-state-id") ValueState myState) {
        *     myState.read();
        *     myState.write(...);
        *   }
    @@ -480,17 +480,17 @@ public  RestrictionTracker restrictionTracker() {
        *
        * 
    {@code
        * new DoFn, Baz>() {
    -   *   @TimerId("my-timer-id")
    +   *   {@literal @}TimerId("my-timer-id")
        *   private final TimerSpec myTimer = TimerSpecs.timerForDomain(TimeDomain.EVENT_TIME);
        *
    -   *   @ProcessElement
    +   *   {@literal @}ProcessElement
        *   public void processElement(
        *       ProcessContext c,
    -   *       @TimerId("my-timer-id") Timer myTimer) {
    +   *       {@literal @}TimerId("my-timer-id") Timer myTimer) {
        *     myTimer.setForNowPlus(Duration.standardSeconds(...));
        *   }
        *
    -   *   @OnTimer("my-timer-id")
    +   *   {@literal @}OnTimer("my-timer-id")
        *   public void onMyTimer() {
        *     ...
        *   }
    @@ -578,7 +578,7 @@ public  RestrictionTracker restrictionTracker() {
        * 
      *
    • Its first argument must be a {@link DoFn.ProcessContext}. *
    • If one of its arguments is a subtype of {@link RestrictionTracker}, then it is a splittable {@link DoFn} subject to the * separate requirements described below. Items below are assuming this is not a splittable * {@link DoFn}. *
    • If one of its arguments is {@link BoundedWindow}, this argument corresponds to the window diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java index a3a306a16d3f..0684a5c83e6f 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java @@ -96,7 +96,7 @@ * *

      For example: * - *

      <{@code
      + * 
      {@code
        * PCollection lines = ...;
        * PCollection words =
        *     lines.apply(ParDo.of(new DoFn() {
      diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
      index d750efc9fedc..5fafc0a1ec23 100644
      --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
      +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/View.java
      @@ -213,7 +213,7 @@ public static  AsMap asMap() {
       
         /**
          * Returns a {@link View.AsMultimap} transform that takes a
      -   * {@link PCollection PCollection<KV<K, V>>}
      +   * {@link PCollection PCollection<KV<K, V>>}
          * as input and produces a {@link PCollectionView} mapping
          * each window to its contents as a {@link Map Map<K, Iterable<V>>}
          * for use as a side input.
      diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java
      index 46cf94abd012..1a2de970e399 100644
      --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java
      +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/display/DisplayData.java
      @@ -87,9 +87,8 @@ public static DisplayData from(HasDisplayData component) {
          *
          * 

      Use this method if the type of metadata is not known at compile time. For example: * - *

      -   * {@code
      -   * @Override
      +   * 
      {@code
      +   * {@literal @}Override
          * public void populateDisplayData(DisplayData.Builder builder) {
          *   Optional type = DisplayData.inferType(foo);
          *   if (type.isPresent()) {
      diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
      index 9546b291d4fc..b760e2c1a3ad 100644
      --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
      +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGroupByKey.java
      @@ -43,7 +43,7 @@
        * 

      Example of performing a {@link CoGroupByKey} followed by a * {@link ParDo} that consumes * the results: - *

       {@code
      + * 
      {@code
        * PCollection> pt1 = ...;
        * PCollection> pt2 = ...;
        *
      @@ -57,7 +57,7 @@
        * PCollection finalResultCollection =
        *   coGbkResultCollection.apply(ParDo.of(
        *     new DoFn, T>() {
      - *       @Override
      + *       {@literal @}ProcessElement
        *       public void processElement(ProcessContext c) {
        *         KV e = c.element();
        *         Iterable pt1Vals = e.getValue().getAll(t1);
      @@ -66,7 +66,7 @@
        *         c.output(...some T...);
        *       }
        *     }));
      - * } 
      + * }
      * * @param the type of the keys in the input and output * {@code PCollection}s diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignature.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignature.java index 7087efa30bb1..11f6aa7da5a4 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignature.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignature.java @@ -415,7 +415,7 @@ static OnTimerMethod create(Method targetMethod, String id, List extr /** * Describes a timer declaration; a field of type {@link TimerSpec} annotated with - * {@DoFn.TimerId}. + * {@link DoFn.TimerId}. */ @AutoValue public abstract static class TimerDeclaration { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java index 6b249eef86b5..268766b675aa 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java @@ -21,7 +21,7 @@ /** * Manages concurrent access to the restriction and keeps track of its claimed part for a splittable {@link DoFn}. */ public interface RestrictionTracker { /** diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java index 1ceb880c33e2..4523032eeb82 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java @@ -16,7 +16,7 @@ * limitations under the License. */ /** - * Defines utilities related to splittable + * {@link org.apache.beam.sdk.transforms.DoFn}. */ package org.apache.beam.sdk.transforms.splittabledofn; diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BaseExecutionContext.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BaseExecutionContext.java index 45bbe752c2a8..e26f2b0f62a5 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BaseExecutionContext.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BaseExecutionContext.java @@ -38,7 +38,7 @@ * of {@link StepContext} from {@link #getOrCreateStepContext(String, String)} and * {@link #getAllStepContexts()} without forcing each subclass to override the method, e.g. *
      {@code
      - * @Override
      + * {@literal @}Override
        * StreamingModeExecutionContext.StepContext getOrCreateStepContext(...) {
        *   return (StreamingModeExecutionContext.StepContext) super.getOrCreateStepContext(...);
        * }
      diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BufferedElementCountingOutputStream.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BufferedElementCountingOutputStream.java
      index c17d92d41f8a..b0784cad2bc0 100644
      --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BufferedElementCountingOutputStream.java
      +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/BufferedElementCountingOutputStream.java
      @@ -49,7 +49,7 @@
        * 
      * *

      To read this stream: - *

      
      + * 
      {@code
        * InputStream is = ...
        * long count;
        * do {
      @@ -58,7 +58,7 @@
        *     // read an element from is
        *   }
        * } while(count > 0);
      - * 
      + * }
      * *

      The counts are encoded as variable length longs. See {@link VarInt#encode(long, OutputStream)} * for more details. The end of the iterable is detected by reading a count of 0. diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExecutionContext.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExecutionContext.java index 82d900c53037..f2a79bd0f7bf 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExecutionContext.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExecutionContext.java @@ -41,14 +41,14 @@ public interface ExecutionContext { /** * Hook for subclasses to implement that will be called whenever - * {@link OldDoFn.Context#output} + * {@link org.apache.beam.sdk.transforms.OldDoFn.Context#output} * is called. */ void noteOutput(WindowedValue output); /** * Hook for subclasses to implement that will be called whenever - * {@link OldDoFn.Context#sideOutput} + * {@link org.apache.beam.sdk.transforms.OldDoFn.Context#sideOutput} * is called. */ void noteSideOutput(TupleTag tag, WindowedValue output); @@ -70,14 +70,14 @@ public interface StepContext { /** * Hook for subclasses to implement that will be called whenever - * {@link OldDoFn.Context#output} + * {@link org.apache.beam.sdk.transforms.OldDoFn.Context#output} * is called. */ void noteOutput(WindowedValue output); /** * Hook for subclasses to implement that will be called whenever - * {@link OldDoFn.Context#sideOutput} + * {@link org.apache.beam.sdk.transforms.OldDoFn.Context#sideOutput} * is called. */ void noteSideOutput(TupleTag tag, WindowedValue output); diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayInputStream.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayInputStream.java index 020c45308f97..662ea38f3467 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayInputStream.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayInputStream.java @@ -30,8 +30,9 @@ public ExposedByteArrayInputStream(byte[] buf) { super(buf); } - /** Read all remaining bytes. - * @throws IOException */ + /** + * Read all remaining bytes. + */ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification = "Returns internal buffer by design") public byte[] readAll() throws IOException { if (pos == 0 && count == buf.length) { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayOutputStream.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayOutputStream.java index e2c7e42917a6..e4a8062fe6b0 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayOutputStream.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ExposedByteArrayOutputStream.java @@ -62,8 +62,6 @@ private void fallback() { * no content copy will be involved. * *

      Note: After passing any byte array to this method, it must not be modified again. - * - * @throws IOException */ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification = "Takes ownership of input buffer") public void writeAndOwn(byte[] b) throws IOException { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java index ce4604b7ac9c..54a963b05a6f 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcsUtil.java @@ -301,7 +301,6 @@ long fileSize(GcsPath path, BackOff backoff, Sleeper sleeper) throws IOException * * @param path the GCS filename to read from * @return a SeekableByteChannel that can read the object data - * @throws IOException */ public SeekableByteChannel open(GcsPath path) throws IOException { @@ -319,7 +318,6 @@ public SeekableByteChannel open(GcsPath path) * @param path the GCS file to write to * @param type the type of object, eg "text/plain". * @return a Callable object that encloses the operation. - * @throws IOException */ public WritableByteChannel create(GcsPath path, String type) throws IOException { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MovingFunction.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MovingFunction.java index 7b30d346024e..a8239ce94510 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MovingFunction.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MovingFunction.java @@ -25,8 +25,8 @@ /** * Keep track of the moving minimum/maximum/sum of sampled long values. The minimum/maximum/sum - * is over at most the last {@link #samplePeriodMs}, and is updated every - * {@link #sampleUpdateMs}. + * is over at most the user-specified last {@code samplePeriodMs}, and is updated every + * {@code sampleUpdateMs}. */ public class MovingFunction { /** diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PubsubClient.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PubsubClient.java index 1ac55119d14e..06b776b4b8e2 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PubsubClient.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PubsubClient.java @@ -90,10 +90,10 @@ private static Long asMsSinceEpoch(@Nullable String timestamp) { *

      If {@code timestampLabel} is non-{@literal null} then the message attributes must contain * that label, and the value of that label will be taken as the timestamp. * Otherwise the timestamp will be taken from the Pubsub publish timestamp {@code - * pubsubTimestamp}. Throw {@link IllegalArgumentException} if the timestamp cannot be - * recognized as a ms-since-unix-epoch or RFC3339 time. + * pubsubTimestamp}. * - * @throws IllegalArgumentException + * @throws IllegalArgumentException if the timestamp cannot be recognized as a ms-since-unix-epoch + * or RFC3339 time. */ protected static long extractTimestamp( @Nullable String timestampLabel, @@ -115,7 +115,7 @@ protected static long extractTimestamp( "Cannot interpret value of label %s as timestamp: %s", timestampLabel, value); } - return timestampMsSinceEpoch == null ? 0 : timestampMsSinceEpoch; + return timestampMsSinceEpoch; } /** @@ -443,8 +443,6 @@ public int hashCode() { /** * Publish {@code outgoingMessages} to Pubsub {@code topic}. Return number of messages * published. - * - * @throws IOException */ public abstract int publish(TopicPath topic, List outgoingMessages) throws IOException; @@ -454,8 +452,6 @@ public abstract int publish(TopicPath topic, List outgoingMessa * Return the received messages, or empty collection if none were available. Does not * wait for messages to arrive if {@code returnImmediately} is {@literal true}. * Returned messages will record their request time as {@code requestTimeMsSinceEpoch}. - * - * @throws IOException */ public abstract List pull( long requestTimeMsSinceEpoch, @@ -466,8 +462,6 @@ public abstract List pull( /** * Acknowldege messages from {@code subscription} with {@code ackIds}. - * - * @throws IOException */ public abstract void acknowledge(SubscriptionPath subscription, List ackIds) throws IOException; @@ -475,8 +469,6 @@ public abstract void acknowledge(SubscriptionPath subscription, List ack /** * Modify the ack deadline for messages from {@code subscription} with {@code ackIds} to * be {@code deadlineSeconds} from now. - * - * @throws IOException */ public abstract void modifyAckDeadline( SubscriptionPath subscription, List ackIds, @@ -484,29 +476,21 @@ public abstract void modifyAckDeadline( /** * Create {@code topic}. - * - * @throws IOException */ public abstract void createTopic(TopicPath topic) throws IOException; /* * Delete {@code topic}. - * - * @throws IOException */ public abstract void deleteTopic(TopicPath topic) throws IOException; /** * Return a list of topics for {@code project}. - * - * @throws IOException */ public abstract List listTopics(ProjectPath project) throws IOException; /** * Create {@code subscription} to {@code topic}. - * - * @throws IOException */ public abstract void createSubscription( TopicPath topic, SubscriptionPath subscription, int ackDeadlineSeconds) throws IOException; @@ -514,8 +498,6 @@ public abstract void createSubscription( /** * Create a random subscription for {@code topic}. Return the {@link SubscriptionPath}. It * is the responsibility of the caller to later delete the subscription. - * - * @throws IOException */ public SubscriptionPath createRandomSubscription( ProjectPath project, TopicPath topic, int ackDeadlineSeconds) throws IOException { @@ -529,23 +511,17 @@ public SubscriptionPath createRandomSubscription( /** * Delete {@code subscription}. - * - * @throws IOException */ public abstract void deleteSubscription(SubscriptionPath subscription) throws IOException; /** * Return a list of subscriptions for {@code topic} in {@code project}. - * - * @throws IOException */ public abstract List listSubscriptions(ProjectPath project, TopicPath topic) throws IOException; /** * Return the ack deadline, in seconds, for {@code subscription}. - * - * @throws IOException */ public abstract int ackDeadlineSeconds(SubscriptionPath subscription) throws IOException; diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/StringUtils.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/StringUtils.java index 1c52c1f5f147..3ff844880e71 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/StringUtils.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/StringUtils.java @@ -119,8 +119,8 @@ public static byte[] jsonStringToByteArray(String string) { * *

      Examples: *

        - *
      • {@code some.package.Word.SummaryDoFn} -> "Summary" - *
      • {@code another.package.PairingFn} -> "Pairing" + *
      • {@code some.package.Word.SummaryDoFn} becomes "Summary" + *
      • {@code another.package.PairingFn} becomes "Pairing" *
      * * @throws IllegalArgumentException if the class is anonymous @@ -143,8 +143,8 @@ public static String approximateSimpleName(Class clazz) { * *

      Examples: *

        - *
      • {@code some.package.Word.Summary} -> "Word.Summary" - *
      • {@code another.package.Pairing.Bound} -> "Pairing" + *
      • {@code some.package.Word.Summary} becomes "Word.Summary" + *
      • {@code another.package.Pairing.Bound} becomes "Pairing" *
      */ public static String approximatePTransformName(Class clazz) { diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimerInternals.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimerInternals.java index 8015116d52cc..743f3f796918 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimerInternals.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimerInternals.java @@ -128,15 +128,17 @@ public interface TimerInternals { * * *

      In pictures: - *

      +   * 
      {@code
          *  |              |       |       |       |
          *  |              |   D   |   C   |   B   |   A
          *  |              |       |       |       |
          * GIWM     <=    GOWM <= LOWM <= LIWM <= GIWM
          * (next stage)
          * -------------------------------------------------> event time
      -   * 
      - * where + * }
      + * + *

      where + * *

        *
      • LOWM = local output water mark. *
      • GOWM = global output water mark. diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespace.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespace.java index 9b27b1d841b9..04440cbc67f9 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespace.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespace.java @@ -22,17 +22,17 @@ /** * A namespace used for scoping state stored with {@link StateInternals}. * - *

        Instances of {@code StateNamespace} are guaranteed to have a {@link #hashCode} and - * {@link #equals} that uniquely identify the namespace. + *

        Instances of {@link StateNamespace} are guaranteed to have a {@link Object#hashCode} and + * {@link Object#equals} that uniquely identify the namespace. */ public interface StateNamespace { /** * Return a {@link String} representation of the key. It is guaranteed that this - * {@code String} will uniquely identify the key. + * {@link String} will uniquely identify the key. * - *

        This will encode the actual namespace as a {@code String}. It is - * preferable to use the {@code StateNamespace} object when possible. + *

        This will encode the actual namespace as a {@link String}. It is + * preferable to use the {@link StateNamespace} object when possible. * *

        The string produced by the standard implementations will not contain a '+' character. This * enables adding a '+' between the actual namespace and other information, if needed, to separate @@ -46,11 +46,11 @@ public interface StateNamespace { void appendTo(Appendable sb) throws IOException; /** - * Return an {@code Object} to use as a key in a cache. + * Return an {@link Object} to use as a key in a cache. * *

        Different namespaces may use the same key in order to be treated as a unit in the cache. - * The {@code Object}'s {@code hashCode} and {@code equals} methods will be used to determine - * equality. + * The {@link Object}'s {@link Object#hashCode} and {@link Object#equals} methods will be used to + * determine equality. */ Object getCacheKey(); } diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PDone.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PDone.java index 83d6a9232818..9e8cae4a299f 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PDone.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PDone.java @@ -24,7 +24,7 @@ /** * {@link PDone} is the output of a {@link PTransform} that has a trivial result, - * such as a {@link Write}. + * such as a {@link org.apache.beam.sdk.io.Write}. */ public class PDone extends POutputValueBase { diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java index 3727f9215d36..1d1075c0cdbb 100644 --- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java +++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java @@ -165,7 +165,7 @@ * read Entities, Properties, * and Keys for more information about {@code Entity} keys. * - *

        Permissions

        + *

        Permissions

        * Permission requirements depend on the {@code PipelineRunner} that is used to execute the * Dataflow job. Please refer to the documentation of corresponding {@code PipelineRunner}s for * more details. diff --git a/sdks/java/io/jdbc/pom.xml b/sdks/java/io/jdbc/pom.xml index a65ed4614477..2eb24bd4dbb6 100644 --- a/sdks/java/io/jdbc/pom.xml +++ b/sdks/java/io/jdbc/pom.xml @@ -48,10 +48,6 @@ org.apache.maven.plugins maven-jar-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - diff --git a/sdks/java/io/kafka/pom.xml b/sdks/java/io/kafka/pom.xml index 184c1c958b7f..200495218b5c 100644 --- a/sdks/java/io/kafka/pom.xml +++ b/sdks/java/io/kafka/pom.xml @@ -52,13 +52,6 @@ org.apache.maven.plugins maven-jar-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:missing - - diff --git a/sdks/java/io/kinesis/pom.xml b/sdks/java/io/kinesis/pom.xml index 76df329e0ea8..439995dfa82c 100644 --- a/sdks/java/io/kinesis/pom.xml +++ b/sdks/java/io/kinesis/pom.xml @@ -52,13 +52,6 @@ org.apache.maven.plugins maven-jar-plugin - - org.apache.maven.plugins - maven-javadoc-plugin - - -Xdoclint:missing - - org.apache.maven.plugins diff --git a/sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java b/sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java index 945eff6ee4f9..91939d475663 100644 --- a/sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java +++ b/sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java @@ -40,32 +40,29 @@ * It follows the usage conventions laid out by other *IO classes like * BigQueryIO or PubsubIOLet's see how you can set up a simple Pipeline, which reads from Kinesis: * - *
        {@code}
        + * 
        {@code
          * p.
          *   apply(KinesisIO.Read.
          *     from("streamName", InitialPositionInStream.LATEST).
          *     using("AWS_KEY", _"AWS_SECRET", STREAM_REGION).
          *     apply( ... ) // other transformations
        - *
        - *

        + * }
        * - *

        - * As you can see you need to provide 3 things: + *

        As you can see you need to provide 3 things: *

          *
        • name of the stream you're going to read
        • - *
        • position in the stream where reading should start. There are two options:
        • + *
        • position in the stream where reading should start. There are two options: *
            *
          • {@link InitialPositionInStream#LATEST} - reading will begin from end of the stream
          • *
          • {@link InitialPositionInStream#TRIM_HORIZON} - reading will begin at * the very beginning of the stream
          • - *
          - *
        • data used to initialize {@link AmazonKinesis} client
        • + *
      • + *
      • data used to initialize {@link AmazonKinesis} client: *
          *
        • credentials (aws key, aws secret)
        • *
        • region where the stream is located
        • - *
        + *
    • *
    - *

    * *

    In case when you want to set up {@link AmazonKinesis} client by your own * (for example if you're using more sophisticated authorization methods like Amazon STS, etc.) @@ -73,35 +70,33 @@ * *

    {@code
      * public class MyCustomKinesisClientProvider implements KinesisClientProvider {
    - *   @Override
    + *   {@literal @}Override
      *   public AmazonKinesis get() {
      *     // set up your client here
      *   }
    - * }}
    - * 
    + * } + * }
    * - * Usage is pretty straightforward: + *

    Usage is pretty straightforward: * - *

    {@code}
    + * 
    {@code
      * p.
      *   apply(KinesisIO.Read.
      *    from("streamName", InitialPositionInStream.LATEST).
      *    using(MyCustomKinesisClientProvider()).
      *    apply( ... ) // other transformations
    - * 
    - *

    + * }
    * *

    There’s also possibility to start reading using arbitrary point in time - * in this case you need to provide {@link Instant} object: * - *

    {@code}
    + * 
    {@code
      * p.
      *   apply(KinesisIO.Read.
      *     from("streamName", instant).
      *     using(MyCustomKinesisClientProvider()).
      *     apply( ... ) // other transformations
    - * 
    - *

    + * }
    * */ public final class KinesisIO { diff --git a/sdks/java/io/mongodb/pom.xml b/sdks/java/io/mongodb/pom.xml index d674e63e8329..d0ae6ace4c62 100644 --- a/sdks/java/io/mongodb/pom.xml +++ b/sdks/java/io/mongodb/pom.xml @@ -48,10 +48,6 @@ org.apache.maven.plugins maven-jar-plugin - - org.apache.maven.plugins - maven-javadoc-plugin -