Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily difference for "Recovered", "Deaths", and "Tested" charts incorrectly showing as "(+0)" #429

Open
bowdentom opened this issue Jul 31, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bowdentom
Copy link

Screen Shot 2020-07-31 at 17 42 48

The source data from Google Sheets shows the following:

Screen Shot 2020-07-31 at 17 53 51

The error appears to be in the JSON api file at https://data.covid19japan.com/summary/latest.json
which is showing:

Screen Shot 2020-07-31 at 17 58 40

@reustle

@liquidx
Copy link
Collaborator

liquidx commented Jul 31, 2020

This is working as intended. We hadn't added the numbers for 2020-07-31 (the latest one was in 2020-07-30 in your screenshot), so we can't show any increases until we actually add the numbers

@bowdentom
Copy link
Author

I don’t think this should be the intended working behavior. The user will look at the difference number, and conclude that there has been no change since the previous day. In fact, there has been a change since the previous day, so showing "(+0)" is plain incorrect.

@vlumi
Copy link
Contributor

vlumi commented Aug 3, 2020

I agree with @bowdentom. Since the current day's numbers will be tentative and incomplete for the majority of the time, I feel that they should not be promoted so much. Wouldn't it make more sense to keep the confirmed, final previous day's numbers in the spotlight instead, and push the tentative numbers a bit down?

@liquidx
Copy link
Collaborator

liquidx commented Aug 3, 2020

Fair point, ok, how about if we show yesterday's increase then until there's data for the current day? Will that be better?

@liquidx liquidx self-assigned this Nov 24, 2020
@reustle
Copy link
Owner

reustle commented Jan 22, 2021

@liquidx Maybe this can be split into 2 issues?

  1. If not done already, we can not show the difference if it is 0, so (+0) goes away

  2. Move the other half of this issue (regarding the data) to the data repo

@reustle reustle added the enhancement New feature or request label Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants