Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Label incoming issues with priority-5-triage label #8960

Closed
HonkingGoose opened this issue Mar 3, 2021 · 9 comments · Fixed by #8962
Closed

chore: Label incoming issues with priority-5-triage label #8960

HonkingGoose opened this issue Mar 3, 2021 · 9 comments · Fixed by #8962
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

What would you like Renovate to be able to do?

We need a way to remind ourselves to add a proper priority label to incoming issues.

I'm seeing new incoming issues which do not have a priority label.
I suspect this is because it's not longer a fully manual job to add labels, that the maintainers and triagist forget to add the priority label.

Did you already have any implementation ideas?

I would like to propose we add a priority-5-triage label to the repository.
We also adjust the issue templates to add this new label to incoming issues.
This will serve as a reminder to maintainers/triagists that they should assign a proper priority to the issue.
As an added benefit, we can search for the new triage label to find any issues that don't yet have a "real" priority.

I'm suggesting this because we now add some labels to incoming issues automatically.
This makes it easy to forget to add a priority label.
Maybe having a triage label can help with this?

I'm willing to make a PR to add the label to the issue templates, but I cannot add a new label myself, as I don't have the rights to do that. 😄

Or maybe you guys have a better idea? 😄

@HonkingGoose HonkingGoose added status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels Mar 3, 2021
@rarkins
Copy link
Collaborator

rarkins commented Mar 3, 2021

Instead would it work to have a search for all issues which are missing a priority label?

@HonkingGoose
Copy link
Collaborator Author

Instead would it work to have a search for all issues which are missing a priority label?

That would cover all use cases, both old and newer issues.
But it's less easy to use, as you need to copy/paste the query from the triage markdown document.
When you have a label, you can just search for all occurrences of that label by clicking on the label.

I'll let you decide which you prefer. 😉

@rarkins
Copy link
Collaborator

rarkins commented Mar 3, 2021

ok, no problem with the new label

@HonkingGoose HonkingGoose added status:in-progress Someone is working on implementation and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 3, 2021
@viceice
Copy link
Member

viceice commented Mar 3, 2021

Can /should we remove status:... from closed issues?

@HonkingGoose
Copy link
Collaborator Author

If we want to remove status: badges after issues are closed, we should find a way to automate that, because everybody is going to forget to do that. 😄

Also on a related note: the status:in-progress badge should probably be applied automatically via a bot action once a issue is targeted with Closed #<issue_number> via a PR.
I notice issues are still labeled status:requirements or status:ready after somebody targets them for closure with a PR.

@viceice
Copy link
Member

viceice commented Mar 3, 2021

I think we need a new issue to clarify those things 😉

@HonkingGoose

This comment has been minimized.

@HonkingGoose
Copy link
Collaborator Author

See issues #8964 and #8965 to discuss this further.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 24.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants