Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn resolution updated to wrong value #8729

Closed
1 of 5 tasks
Turbo87 opened this issue Feb 17, 2021 · 4 comments
Closed
1 of 5 tasks

yarn resolution updated to wrong value #8729

Turbo87 opened this issue Feb 17, 2021 · 4 comments
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others stale status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Feb 17, 2021

What Renovate type, platform and version are you using?

self-hosted on GitLab, Vesion 24.37.0

Describe the bug

The MR description says it updated the resolution to a fixed version, but instead it got replaced with a range.

What might be relevant is that we're using:

      "rangeStrategy": "bump",
      "packageRules": [
        {
          "depTypeList": [
            "dependencies"
          ],
          "rangeStrategy": "widen"
        }
      ]

Bildschirmfoto 2021-02-17 um 09 17 34

Bildschirmfoto 2021-02-17 um 09 17 40

Relevant debug logs

DEBUG: processBranch with 2 upgrades (repository=foo/bar, dependencies=ember-concurrency, branch=deps-3afdb7030a)
DEBUG: Setting current branch to master (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: latest commit (repository=foo/bar, branch=deps-3afdb7030a)
       "branchName": "master",
       "latestCommitDate": "2021-02-17T05:54:18+00:00"
DEBUG: getBranchPr(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: findPr(deps-3afdb7030a, undefined, open) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getPr(1573) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getBranchStatus(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Got res with 6 results (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: branchExists=true (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Branch pr rebase requested: false (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Branch has 1 upgrade(s) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Checking if PR has been edited (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Found existing branch PR (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Checking schedule(at any time, null) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: No schedule defined (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Branch already exists (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getBranchPr(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: findPr(deps-3afdb7030a, undefined, open) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getPr(1573) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getBranchStatus(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Got res with 6 results (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Branch does not need rebasing (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Using reuseExistingBranch: true (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: manager.getUpdatedPackageFiles() (repository=foo/bar, branch=deps-3afdb7030a)
       "reuseExistingBranch": true,
       "branchName": "deps-3afdb7030a"
DEBUG: npm.updateDependency(): resolutions.ember-concurrency = 2.0.1 (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Upgraded dependency exists in yarn resolutions but is different version (repository=foo/bar, branch=deps-3afdb7030a)
       "depName": "ember-concurrency",
       "depKey": "ember-concurrency",
       "oldVersion": "^0.8.14 || ^0.9.0 || ^0.10.0 || ^1.0.0 || ^2.0.0",
       "resolutionsVersion": "2.0.1"
DEBUG: Need to update package file so will rebase first (repository=foo/bar, packageFile=package.json, branch=deps-3afdb7030a)
       "depName": "ember-concurrency"
DEBUG: manager.getUpdatedPackageFiles() (repository=foo/bar, branch=deps-3afdb7030a)
       "reuseExistingBranch": false,
       "branchName": "deps-3afdb7030a"
DEBUG: npm.updateDependency(): resolutions.ember-concurrency = 2.0.1 (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Upgraded dependency exists in yarn resolutions but is different version (repository=foo/bar, branch=deps-3afdb7030a)
       "depName": "ember-concurrency",
       "depKey": "ember-concurrency",
       "oldVersion": "1.3.0",
       "resolutionsVersion": "2.0.1"
DEBUG: Updating packageFile content (repository=foo/bar, packageFile=package.json, branch=deps-3afdb7030a)
       "depName": "ember-concurrency"
DEBUG: npm.updateDependency(): dependencies.ember-concurrency = ^0.8.14 || ^0.9.0 || ^0.10.0 || ^1.0.0 || ^2.0.0 (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Upgraded dependency exists in yarn resolutions but is different version (repository=foo/bar, branch=deps-3afdb7030a)
       "depName": "ember-concurrency",
       "depKey": "ember-concurrency",
       "oldVersion": "^0.8.14 || ^0.9.0 || ^0.10.0 || ^1.0.0",
       "resolutionsVersion": "2.0.1"
DEBUG: Updating packageFile content (repository=foo/bar, packageFile=package.json, branch=deps-3afdb7030a)
       "depName": "ember-concurrency"
DEBUG: Updated 1 package files (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Getting updated lock files (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: lock file dirs (repository=foo/bar, branch=deps-3afdb7030a)
       "dirs": {
         "yarnLockDirs": ["yarn.lock"],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing package.json files (repository=foo/bar, branch=deps-3afdb7030a)
       "packageFiles": ["package.json"]
DEBUG: Writing any updated package files (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Writing package.json (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: No npmrc file found in repository (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Writing updated .npmrc file to .renovate/repos/gitlab/foo/bar/.npmrc (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Generating yarn.lock for . (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Spawning yarn install to create .renovate/repos/gitlab/foo/bar/yarn.lock (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Updating yarn.lock only - skipping node_modules (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Using node constraint "10.* || >= 12.*" from package.json (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Augmenting constraint to avoid node 15 (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Performing yarn dedupe fewer (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Executing command (repository=foo/bar, branch=deps-3afdb7030a)
       "command": "yarn install --ignore-engines --ignore-platform --network-timeout 100000"
DEBUG: exec completed (repository=foo/bar, branch=deps-3afdb7030a)
       "cmd": "yarn install --ignore-engines --ignore-platform --network-timeout 100000",
       "durationMs": 76174,
       "stdout": "\u001b[2K\u001b[1G\u001b[2m[1/4]\u001b[22m Resolving packages...\n\u001b[2K\u001b[1G\u001b[2m[2/4]\u001b[22m Fetching packages...\n\u001b[2K\u001b[1G\u001b[2m[3/4]\u001b[22m Linking dependencies...\n\u001b[2K\u001b[1G\u001b[2m[4/4]\u001b[22m Building fresh packages...\n\u001b[2K\u001b[1G\u001b[32msuccess\u001b[39m Saved lockfile.\n",
       "stderr": ""
DEBUG: Executing command (repository=foo/bar, branch=deps-3afdb7030a)
       "command": "npx yarn-deduplicate --strategy fewer"
DEBUG: exec completed (repository=foo/bar, branch=deps-3afdb7030a)
       "cmd": "npx yarn-deduplicate --strategy fewer",
       "durationMs": 2277,
       "stdout": "",
       "stderr": "npx: installed 6 in 1.858s\n"
DEBUG: Executing command (repository=foo/bar, branch=deps-3afdb7030a)
       "command": "yarn install --ignore-engines --ignore-platform --network-timeout 100000"
DEBUG: exec completed (repository=foo/bar, branch=deps-3afdb7030a)
       "cmd": "yarn install --ignore-engines --ignore-platform --network-timeout 100000",
       "durationMs": 885,
       "stdout": "\u001b[2K\u001b[1G\u001b[2m[1/4]\u001b[22m Resolving packages...\n\u001b[2K\u001b[1G\u001b[32msuccess\u001b[39m Already up-to-date.\n",
       "stderr": ""
DEBUG: yarn.lock needs updating (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: updateYarnOffline resolvedPaths (repository=foo/bar, branch=deps-3afdb7030a)
       "resolvedPaths": []
DEBUG: Updated 1 lock files (repository=foo/bar, branch=deps-3afdb7030a)
       "updatedArtifacts": ["yarn.lock"]
DEBUG: 2 file(s) to commit (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Committing files to branch deps-3afdb7030a (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: No file changes detected. Skipping commit (repository=foo/bar, branch=deps-3afdb7030a)
       "branchName": "deps-3afdb7030a",
       "fileNames": ["package.json", "yarn.lock"]
DEBUG: Checking if we can automerge branch (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: mergeStatus=no automerge (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Ensuring PR (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: There are 0 errors and 0 warnings (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getBranchPr(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: findPr(deps-3afdb7030a, undefined, open) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getPr(1573) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: getBranchStatus(deps-3afdb7030a) (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Got res with 6 results (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Found existing PR (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Removing duplicate release notes (repository=foo/bar, branch=deps-3afdb7030a)
       "depName": "ember-concurrency"
DEBUG: Processing existing PR (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Merge Request #1573 does not need updating (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Ensuring comment "⚠️ Artifact update problem" in #1573 is removed (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Getting comments for #1573 (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Found 9 comments (repository=foo/bar, branch=deps-3afdb7030a)
DEBUG: Checking #1573 for automerge (repository=foo/bar, branch=deps-3afdb7030a)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=foo/bar, branch=deps-3afdb7030a)

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

If a repro is necessary I can try to create one later this week :)

@viceice viceice added manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality auto:reproduction A minimal reproduction is necessary to proceed labels Feb 17, 2021
@github-actions
Copy link
Contributor

Hi there,
The Renovate team needs your help! To fix the problem, we first need to know exactly what's causing the bug. A minimal reproduction help us to pinpoint the exact cause of the bug.
To get started, please read our guide on minimal reproductions to understand what is needed.
We may close the issue if you have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.
Good luck,
The Renovate team

@HonkingGoose HonkingGoose added the status:requirements Full requirements are not yet known, so implementation should not be started label Feb 25, 2021
@github-actions
Copy link
Contributor

This issue has been labeled with status:requirements. This indicates that we don't know enough to start work and further requirements or a reproduction are needed first.

This label will be replaced with status:ready once all requirements and reproductions necessary to start work have been met.

If it's not clear what is missing to move this issue forward, ask for clarification in a new comment. If you think we already have what we need to move forward, mention this in a new comment.

@github-actions
Copy link
Contributor

When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.

@github-actions github-actions bot added the stale label Mar 18, 2021
@github-actions
Copy link
Contributor

This bug report has been closed as we need a reproduction to work on this. If the original poster or anybody else with the same problem discovers that they can reproduce it, please create a new issue, and reference this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:reproduction A minimal reproduction is necessary to proceed manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others stale status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants