Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate not checking all the relevant files before doing a merge commit for aws-cdk packages. #8484

Closed
1 of 5 tasks
Ranjith072 opened this issue Feb 1, 2021 · 7 comments
Closed
1 of 5 tasks
Labels
auto:reproduction A minimal reproduction is necessary to proceed priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started

Comments

@Ranjith072
Copy link

Ranjith072 commented Feb 1, 2021

What Renovate type, platform and version are you using?

hosted App

Describe the bug

Renovate is updating the files partially since last week, we are using a aws cdk which uses both node js package.json and individual python packages from pypy, whenever there is a new version is released renovate should update both package.json and python setup.py file in the same pull request and it was working well till the last merge made by renovate .
in the last merge renovate only updated the package.json didnt update the setup.py .

Relevant debug logs

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context

image

@Ranjith072
Copy link
Author

debug_logs.txt

@viceice
Copy link
Member

viceice commented Feb 1, 2021

renovate.json

{
  "fileName": "renovate.json",
  "config": {
    "extends": [
      "config:base"
    ],
    "automergeType": "branch",
    "automerge": true,
    "masterIssue": true,
    "major": {
      "automerge": false
    },
    "pin": {
      "automerge": true
    },
    "pinDigests": true,
    "packageRules": [
      {
        "packageNames": [
          "awscli",
          "aws-sdk",
          "boto3",
          "boto3-stubs",
          "botocore"
        ],
        "extends": [
          "schedule:monthly"
        ],
        "stabilityDays": 0,
        "prNotPendingHours": 0,
        "groupName": "aws packages"
      },
      {
        "packagePatterns": [
          "^org\\.jetbrains\\.kotlinx:"
        ],
        "versionScheme": "semver"
      }
    ],
    "lockFileMaintenance": {
      "enabled": true
    },
    "ignorePaths": [
      "sql-server-dependency/Dockerfile"
    ],
    "stabilityDays": 3,
    "prNotPendingHours": 74,
    "timezone": "Europe/Oslo",
    "semanticCommits": true
  }

@viceice viceice added priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality status:ready labels Feb 1, 2021
@viceice
Copy link
Member

viceice commented Feb 1, 2021

Please provide a minimal reproduction repo and fully fill the issue template

@viceice viceice added priority-4-low Low priority, unlikely to be done unless it becomes important to more people auto:reproduction A minimal reproduction is necessary to proceed status:requirements Full requirements are not yet known, so implementation should not be started and removed priority-2-high Bugs impacting wide number of users or very important features status:ready type:bug Bug fix of existing functionality labels Feb 1, 2021
@Ranjith072
Copy link
Author

i am not if this can be reproduced as it happened for the first time, whenever aws cdk releases new version it will usually update both setup.py and package.json together.

@rarkins
Copy link
Collaborator

rarkins commented Feb 1, 2021

Please reopen if you can reproduce

@rarkins rarkins closed this as completed Feb 1, 2021
@Ranjith072
Copy link
Author

for reproduction ,i have reverted the package.json and package-lock.json and an hour after i see the PR back with the same changes.
image

@viceice
Copy link
Member

viceice commented Feb 1, 2021

@Ranjith072 Please read this and create a public reproduction repo.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:reproduction A minimal reproduction is necessary to proceed priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started
Projects
None yet
Development

No branches or pull requests

3 participants