Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support silent/full modes #26724

Closed
rarkins opened this issue Jan 18, 2024 · 2 comments · Fixed by #28396
Closed

Support silent/full modes #26724

rarkins opened this issue Jan 18, 2024 · 2 comments · Fixed by #28396
Assignees
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 18, 2024

Describe the proposed change(s).

This requirement is primarily for use in the Mend app, but may also be useful to self-hosted scenarios too.

In the app we want to support three main concepts/modes:

  • Silent: same as dryRun=lookup but also allows checkedBranches to trigger the creation of branches/PRs. Any pre-existing branches should remain open, be updated, etc. Another way of thinking of this is like prCreation=approval but without the dependency dashboard issue. It could alternatively be named like "Scan only" or "On demand"
  • Remediation: same as silent (allows checkedBranches) but defaults to prCreation=immediate for remediation PRs, i.e. vulnerability fixes. This would be a first-class way to support the people who want "only security fixes" without needing to play with packageRules
  • Full (default): same as today

The concept of dryRun would still exist and be compatible with and override the above. e.g. if -mode=silent and checkedBranches=renovate/foo and dryRun=lookup then the run wouldn't create any branch.

This mode should be user-configurable, e.g. if the user configures mode=remediation in renovate.json then it would override anything set by the app in global config.

@rarkins rarkins added type:feature Feature (new functionality) priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Jan 18, 2024
@HonkingGoose
Copy link
Collaborator

This feature will need a new page in the docs, that explains what each mode does, how to see which mode is active and any warnings/gotchas.

Also, it should be very clear to users what mode Renovate is running in! I'm thinking of a new "mode" field in Renovate's Dependency Dashboard and its PRs. Did you think about how to show the mode to the users already?

@rarkins rarkins self-assigned this Jan 22, 2024
@rarkins rarkins added the status:in-progress Someone is working on implementation label Jan 22, 2024
@rarkins rarkins changed the title Support silent/remediation/full modes Support silent/full modes Apr 14, 2024
@rarkins rarkins mentioned this issue Apr 14, 2024
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.344.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants