Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a scheduled GitHub Action to update data #17050

Closed
JamieMagee opened this issue Aug 8, 2022 · 5 comments
Closed

Create a scheduled GitHub Action to update data #17050

JamieMagee opened this issue Aug 8, 2022 · 5 comments
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@JamieMagee
Copy link
Contributor

Describe the proposed change(s).

Currently we have some static data, with update scripts, that are manually run. There is:

We should add a GitHub Actions pipeline that runs these tasks on a weekly basis, and opens a pull request with any changes.

Footnotes

  1. https://github.com/renovatebot/renovate/blob/main/data/debian-distro-info.json

  2. https://github.com/renovatebot/renovate/blob/main/data/ubuntu-distro-info.json

  3. https://github.com/renovatebot/renovate/blob/main/tools/distro-json-generate.mjs

@JamieMagee JamieMagee added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Aug 8, 2022
@JamieMagee
Copy link
Contributor Author

We should also look into automating the sync of Node.js release schedule data1 as part of this. No update script is required, but the file is synced from upstream2

Footnotes

  1. https://github.com/renovatebot/renovate/blob/main/data/node-js-schedule.json

  2. https://github.com/nodejs/Release/blob/main/schedule.json

@HonkingGoose
Copy link
Collaborator

Yeah I keep manually syncing that node-js-schedule.json file with upstream. 😄

We also have a repository that we intended to use as source for the node.js schedule, with some extra tools to use in Renovate: https://github.com/renovatebot/node-schedule.

I think the big idea was that we "package up" the node-schedule repository and use it as a dependency in our renovate repository. I don't know if that is still something we want to do. So before you decide what to do, check the node-schedule repository first.

I remember we did a lot of work to node-schedule repository somewhat ready for use, but we still have some issues. But this is all a sunk cost anyway, and maybe we're better off using a GitHub Action to update our data things.

@HonkingGoose
Copy link
Collaborator

@JamieMagee does your PR #17080 close this issue? Or do you need/want to do more stuff before closing this issue?

@JamieMagee
Copy link
Contributor Author

Yeah, I think so. I wasn't sure if you wanted to keep this issue open to discuss node-schedule work.

@HonkingGoose
Copy link
Collaborator

I'm closing this issue as done via PR #17080.

We should discuss the future of the node-schedule project in this issue:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

2 participants