Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ladda spinner not showing when button also has ngDisabled #38

Open
MattDionis opened this issue Oct 27, 2015 · 3 comments
Open

Ladda spinner not showing when button also has ngDisabled #38

MattDionis opened this issue Oct 27, 2015 · 3 comments

Comments

@MattDionis
Copy link

I have a button that looks like the below. When I remove the ng-disabled everything works fine, otherwise the spinner never appears.

<button
  ladda="vm.runningReport"
  data-style="zoom-in"
  class="btn btn-default"
  uib-tooltip="Run Report"
  tooltip-placement="top"
  ng-disabled="vm.parameters.length > 0 && !vm.parametersSupplied(vm.parameters.values)"
  ng-click="vm.run(query)">
  <i class="glyphicon glyphicon-play text-primary"></i>
</button>
@subicura
Copy link
Contributor

@MattDionis I think this is complex issue. Can you show me demo page?

@ziaulain
Copy link

@MattDionis got any solution to this? i m getting same issue...

@theodorejb
Copy link

theodorejb commented Nov 28, 2016

Here's a Plunker demonstrating a possibly related bug when using angular-ladda with Angular 1.6: https://plnkr.co/edit/dxQtXpnl3yaXPNE0KCB5?p=preview.

Update: looks like this is due to an intentional change to not remove boolean attributes when they are set to a blank string: angular/angular.js@3faf450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants