Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a parameter to plot_confusion_matrix() to hide overlaid counts #89

Closed
echan5 opened this issue Aug 9, 2018 · 7 comments
Closed

Comments

@echan5
Copy link
Contributor

echan5 commented Aug 9, 2018

Hi @reiinakano,

Thank you for this great repo! I am using plot_confusion_matrix() but my counts are quite large so the overlaid counts end up overlapping each other and result in a cluttered plot. I was wondering if I could submit a pull request to update this function to add a hide_counts parameter to give the option to not plot the counts? I've already forked and created a branch with the changes. Thank you!

@reiinakano
Copy link
Owner

That sounds good to me. Could you also provide an example image before and after?

@echan5
Copy link
Contributor Author

echan5 commented Aug 15, 2018

Great, and sure, an example image of before vs after would be:
screen shot 2018-08-14 at 8 10 59 pm

@echan5
Copy link
Contributor Author

echan5 commented Aug 15, 2018

pull request is now here: #90

@echan5
Copy link
Contributor Author

echan5 commented Aug 16, 2018

I tried pip install scikit-plot (after pip uninstall scikit-plot) but it seems like it's not installing the updated version with the new parameter (tried the function but it's not recognizing hide_counts). It however did work if I installed via pip install git+https://github.com/reiinakano/scikit-plot. What needs to be done to make it work the first way? I realized I forgot to increase the version in setup.py and I'm not sure if that's related. Thanks!

@reiinakano
Copy link
Owner

Hi @echan5, I haven't released a new version of scikit plot yet so you won't get it on pypi. I'll probably do a release over the weekend. For now, please stick with the solution you found, which is installing directly from master

@echan5
Copy link
Contributor Author

echan5 commented Aug 16, 2018

Got it, thank you!

@reiinakano
Copy link
Owner

New version with your patch is now out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants