Attempt to find the correct path for openssl. #1166
Conversation
The installation path for openssl may vary depending on the way used for its installation and the macOS version. This commit attempts to find the correct path for openssl to use.
iddm
force-pushed
the
fix-macos-building
branch
from
8067838 to
377106f
Compare
|
It seems that the project this was needed for doesn't need these changes anymore as it simply overrides the variable |
|
IMHO this is still a good idea. @michael-grunder due to HOMEBREW I think it should still be considered. |
|
@chayim Sure, I'm happy to tweak the PR a little bit and get it merged. Ideally, we'd want someone to confirm the logic works on these older macOS systems since I only have a newer one |
|
I reworked the tests slightly in 345d0b5 which appear seem to work on old macOS systems (e.g. CI) and on my newer M1. It's pretty much the same logic, only I am limiting the mac based searching to mac systems, and also searching first for the new path, and falling back to the old one. @chayim Let me know what you think. |
|
Closing in favor of #1169. I incorporated @vityafx's commits and reworked them a touch. |
The installation path for openssl may vary depending on the way used for its installation and the macOS version.
This commit attempts to find the correct path for openssl to use.