Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Request] To change waitForBreakPoint() argument timeout datatype #1535

Closed
kumarmaxwell opened this issue Sep 20, 2024 · 0 comments · Fixed by #1548
Closed

[🚀 Request] To change waitForBreakPoint() argument timeout datatype #1535

kumarmaxwell opened this issue Sep 20, 2024 · 0 comments · Fixed by #1548
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kumarmaxwell
Copy link

Describe the request

async waitForBreakPoint(timeout = undefined): Promise<void> {
	let btn = await this.getDriver().wait(until.elementLocated(DebugToolbar.locators.DebugToolbar.button('continue')));
	await this.getDriver().wait(async () => {
		try {
			const enabled = await btn.isEnabled();
			return enabled;
		} catch (err) {
			btn = await this.findElement(DebugToolbar.locators.DebugToolbar.button('continue'));
		}
	}, timeout);
}

the above snippet is from workbench\DebugToolbar.ts
could you change the argument timeout datatype from undefined to number. This will give us more explicit control and easier to manage.

Usage

async waitForBreakPoint(timeout: number | undefined = undefined): Promise<void> {
...
...
}

Something like this will help us a lot

@kumarmaxwell kumarmaxwell added enhancement New feature or request new-issue New issue which was not discussed yet labels Sep 20, 2024
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Oct 2, 2024
@djelinek djelinek self-assigned this Oct 2, 2024
@djelinek djelinek moved this from New to In Progress in ExTester Oct 2, 2024
@djelinek djelinek added this to the NEXT milestone Oct 2, 2024
@djelinek djelinek linked a pull request Oct 3, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in ExTester Oct 3, 2024
@djelinek djelinek modified the milestones: NEXT, 8.8.0 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants