Promote ConsolePlugin API version to v1 #481
Conversation
Signed-off-by: Yi Cai <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
/test v4.8-kuttl-sequential |
|
/retest |
|
/test v4.8-kuttl-sequential |
|
/test v4.10-kuttl-sequential |
|
/test all |
|
/retest |
|
/test all |
|
/retest |
main.go
Outdated
| @@ -113,7 +112,6 @@ func main() { | |||
| registerComponentOrExit(mgr, operatorsv1alpha1.AddToScheme) | |||
| registerComponentOrExit(mgr, argoapi.AddToScheme) | |||
| registerComponentOrExit(mgr, configv1.AddToScheme) | |||
| registerComponentOrExit(mgr, consolepluginv1.AddToScheme) | |||
There was a problem hiding this comment.
@ciiay did you mean to update or remove this line? without it the console plugin cannot be deployed at all
please add it back and update the reference
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v4.11-kuttl-parallel |
|
/retest |
|
Hi @ciiay |
|
@ciiay: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing this, please reopen if required |
What type of PR is this?
/kind bug
What does this PR do / why we need it:
ConsolePlugin API has been promoted to v1, we need to update the console plugin CR to pick up the changes.
It's related to GITOPS-2646 to enable i18n in upgraded version.
Which issue(s) this PR fixes:
Fixes GITOPS-2646
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Test ConsolePlugin works.