-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove DISABLE_DEX environment variable from bundle manifests #364
fix: Remove DISABLE_DEX environment variable from bundle manifests #364
Conversation
Hi @wanderboessenkool. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Remove DISABLE_DEX environment variable from the gitops-operator-controller-manager manifest in the clusterserviceversion manifest. - Fixes redhat-developer#362 Signed-off-by: Wander Boessenkool <[email protected]>
33382e2
to
69483d1
Compare
Signed-off-by: Wander Boessenkool <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Fixes bug #362
Have you updated the necessary documentation?
The documentation is already okay
Which issue(s) this PR fixes:
Fixes #362
The clusterserviceversion manifests set the
DISABLE_DEX: false
environment variable on thegitops-operator-controller-manager
deployment, causing a torrent ofDeprecationNotice
events without a timestamp.Test acceptance criteria:
How to test changes / Special notes to the reviewer: