You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way we are currently using these hooks in our repo, most probably we are safe for now as arguments passed to the dependency list of the useEffect are mostly static throughout the lifecycle of the component, but generic hooks should be agnostic of such assumptions.
The text was updated successfully, but these errors were encountered:
Refer: https://react.dev/learn/you-might-not-need-an-effect#fetching-data
We don't have such clean-ups for:
https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/hooks/useK8sList.ts
https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/hooks/k8s-get-hook.ts
https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/hooks/custom-prometheus-poll/use-url-poll.ts
The way we are currently using these hooks in our repo, most probably we are safe for now as arguments passed to the dependency list of the
useEffect
are mostly static throughout the lifecycle of the component, but generic hooks should be agnostic of such assumptions.The text was updated successfully, but these errors were encountered: