Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QuickDiscouragedCallRule to support Quick 7 #5072

Closed
2 tasks done
stonko1994 opened this issue Jun 21, 2023 · 0 comments · Fixed by #5073
Closed
2 tasks done

Update QuickDiscouragedCallRule to support Quick 7 #5072

stonko1994 opened this issue Jun 21, 2023 · 0 comments · Fixed by #5073
Assignees
@SimplyDanny
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@stonko1994
Copy link
Contributor

stonko1994 commented Jun 21, 2023 •
edited
Loading

New Issue Checklist

Describe the bug

Quick 7 changed the spec() function from an instance method to a class method. The current implementation does not handle this case.

- override func spec() {
+ override static func spec() {

Environment

  • SwiftLint version (run swiftlint version to be sure)? 0.52.2
  • Installation method used (Homebrew, CocoaPods, building from source, etc)? Mint
@SimplyDanny SimplyDanny mentioned this issue Jun 21, 2023
Merged
@SimplyDanny SimplyDanny added the enhancement Ideas for improvements of existing features and rules. label Jun 21, 2023
@SimplyDanny SimplyDanny self-assigned this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimplyDanny SimplyDanny

Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle static spec methods in quick_discouraged_call rule SimplyDanny/SwiftLint
2 participants
@stonko1994 @SimplyDanny