Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease SuperfluousDisableCommandRule default severity #2250

Closed
fredpi opened this issue Jun 21, 2018 · 1 comment
Closed

Decrease SuperfluousDisableCommandRule default severity #2250

fredpi opened this issue Jun 21, 2018 · 1 comment
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@fredpi
Copy link
Collaborator

fredpi commented Jun 21, 2018

Currently, when the sources contain superfluous disable commands, SwiftLint triggers a build error.

There are many cases where such behaviour is counterproductive and misaligned with the goal of SwiftLint to increase overall productivity. While the severity of this rule can be manually adjusted (as seen here for instance), I believe the default case should be to trigger a warning instead.

This is especially important for larger projects where it's not uncommon to have build times over a minute. If the build fails because of a superfluous disable command, e. g. originating from removing one single line of code while a rule like file_length is active, this can be super frustrating and takes away valuable time. This is why I think the default severity should be a warning; if some people still prefer the rule to trigger an error, this can still be changed in the config file.

@marcelofabri marcelofabri added enhancement Ideas for improvements of existing features and rules. and removed O:User labels Jun 24, 2018
@jpsim
Copy link
Collaborator

jpsim commented Jun 24, 2018

Merged in 9cbf16d & 880c3ad

@jpsim jpsim closed this as completed Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

3 participants