You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when the sources contain superfluous disable commands, SwiftLint triggers a build error.
There are many cases where such behaviour is counterproductive and misaligned with the goal of SwiftLint to increase overall productivity. While the severity of this rule can be manually adjusted (as seen here for instance), I believe the default case should be to trigger a warning instead.
This is especially important for larger projects where it's not uncommon to have build times over a minute. If the build fails because of a superfluous disable command, e. g. originating from removing one single line of code while a rule like file_length is active, this can be super frustrating and takes away valuable time. This is why I think the default severity should be a warning; if some people still prefer the rule to trigger an error, this can still be changed in the config file.
The text was updated successfully, but these errors were encountered:
Currently, when the sources contain superfluous disable commands, SwiftLint triggers a build error.
There are many cases where such behaviour is counterproductive and misaligned with the goal of SwiftLint to increase overall productivity. While the severity of this rule can be manually adjusted (as seen here for instance), I believe the default case should be to trigger a warning instead.
This is especially important for larger projects where it's not uncommon to have build times over a minute. If the build fails because of a superfluous disable command, e. g. originating from removing one single line of code while a rule like
file_length
is active, this can be super frustrating and takes away valuable time. This is why I think the default severity should be a warning; if some people still prefer the rule to trigger an error, this can still be changed in the config file.The text was updated successfully, but these errors were encountered: