Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule request: bring back missing_docs #1652

Closed
jdmarshall90 opened this issue Jul 2, 2017 · 11 comments
Closed

Rule request: bring back missing_docs #1652

jdmarshall90 opened this issue Jul 2, 2017 · 11 comments
Labels
rule-request Requests for a new rules.

Comments

@jdmarshall90
Copy link

Any chance this could be revived?
@marcelofabri marcelofabri added the rule-request Requests for a new rules. label Jul 2, 2017
@masters3d
Copy link
Contributor

@marcelofabri What was the rational in removing missing docs?
https://github.com/realm/SwiftLint/pull/1455/files

@marcelofabri
Copy link
Collaborator

It didn't work with Swift 3. There was an issue with more history (I'm on my phone right now, otherwise I'd link it here)

@jpsim
Copy link
Collaborator

jpsim commented Jul 11, 2017

See #728 and SR-2487 for details.

@marcelofabri
Copy link
Collaborator

There's also some discussion in swiftlang/swift#9868.

@marcelofabri marcelofabri reopened this Jul 21, 2017
@marcelofabri
Copy link
Collaborator

Closed by mistake, sorry 😅

@acecilia
Copy link
Contributor

Would be awesome to have this back. Is the fix from swiftlang/swift#11264 already in Swift4? (how can we know in which version a PR was included?) Thanks!

@marcelofabri
Copy link
Collaborator

@acecilia it's not. Luckily it'll be part of Swift 4.1 early next year.

@Nef10
Copy link

Nef10 commented Apr 25, 2018 •
edited
Loading

@marcelofabri any update on this as Swift 4.1 is released now? Do you have checked if it is possible again?

@marcelofabri
Copy link
Collaborator

It should be possible, feel free to send a PR 😊

@Nef10 Nef10 mentioned this issue Apr 26, 2018
Closed
5 tasks
@Nef10
Copy link

Nef10 commented Apr 26, 2018

@marcelofabri see #2172

@marcelofabri
Copy link
Collaborator

Merged in #2318 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-request Requests for a new rules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing_docs rule back
6 participants
@jpsim @marcelofabri @jdmarshall90 @Nef10 @masters3d @acecilia