-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce Input primitive as base for FormInput (#665) #671
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bb9f9e3:
|
Deploy preview for reakit ready! Built with commit bb9f9e3 |
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 144 145 +1
Lines 2662 2664 +2
Branches 748 748
=======================================
+ Hits 2546 2548 +2
Misses 116 116
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Guria! :)
Usually, new components are added as experimental and targeted to the next
branch. But since this is a very simple component I guess we can add it as stable. Anyway, we have to add more instructions on the contributing docs.
Thanks a lot for contributing! Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization. Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail. If you have any questions, let me know! |
@diegohaz have you noted that you still targeted it into |
Yeah! Sorry, I didn't express myself well. We can add this component without the |
Closes #665
It doesn't introduce breaking changes in base package. One who used
useFormInputProps
hook still can continue to use it or migrate to useuseInputProps
instead.It does introduce a small breaking change for
reakit-system-bootstrap
though. It doesn't exportuseFormInputProps
hook anymore.