Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Input primitive as base for FormInput (#665) #671

Merged
merged 1 commit into from
Jun 8, 2020
Merged

feat: introduce Input primitive as base for FormInput (#665) #671

merged 1 commit into from
Jun 8, 2020

Conversation

Guria
Copy link
Contributor

@Guria Guria commented Jun 7, 2020

Closes #665

It doesn't introduce breaking changes in base package. One who used useFormInputProps hook still can continue to use it or migrate to use useInputProps instead.

It does introduce a small breaking change for reakit-system-bootstrap though. It doesn't export useFormInputProps hook anymore.

@Guria Guria requested a review from diegohaz as a code owner June 7, 2020 17:49
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb9f9e3:

Sandbox Source
zen-wood-en149 Configuration

@ariakit-bot
Copy link

ariakit-bot commented Jun 7, 2020

Deploy preview for reakit ready!

Built with commit bb9f9e3

https://deploy-preview-671--reakit.netlify.app

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #671 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         144      145    +1     
  Lines        2662     2664    +2     
  Branches      748      748           
=======================================
+ Hits         2546     2548    +2     
  Misses        116      116           
Impacted Files Coverage Δ
packages/reakit/src/Form/FormInput.ts 100.00% <ø> (ø)
packages/reakit/src/Input/Input.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93dad9...bb9f9e3. Read the comment docs.

@diegohaz diegohaz changed the base branch from master to next June 8, 2020 00:10
@diegohaz diegohaz changed the base branch from next to master June 8, 2020 00:11
@diegohaz diegohaz changed the base branch from master to next June 8, 2020 00:12
Copy link
Member

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guria! :)

Usually, new components are added as experimental and targeted to the next branch. But since this is a very simple component I guess we can add it as stable. Anyway, we have to add more instructions on the contributing docs.

@diegohaz diegohaz merged commit 79d3926 into ariakit:next Jun 8, 2020
@ariakit-bot
Copy link

Thanks a lot for contributing!

Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization.

Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail.

If you have any questions, let me know!

@Guria Guria deleted the input branch June 8, 2020 17:38
@Guria
Copy link
Contributor Author

Guria commented Jun 8, 2020

@diegohaz have you noted that you still targeted it into next branch?

@diegohaz
Copy link
Member

diegohaz commented Jun 8, 2020

Yeah! Sorry, I didn't express myself well. We can add this component without the unstable_ prefix, but it should still be on the next branch as it's a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Input primitive as base for FormInput
3 participants