-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mark Composite
as stable
#667
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 449da2b:
|
Deploy preview for reakit ready! Built with commit 449da2b |
I’m aware that it was unstable API and it was fine to remove it 😃 However this removal of unstable prefix l, it causes issues In WordPress packages. See WordPress/gutenberg#23332. When someone is on older version of WordPress packages that worked with Reakit 1.0, it stops working with Reakit 1.1 because references are now invalid. Would you consider keeping aliases until Reakit 2.0? |
This PR marks the
Composite
module as stable, except theCompositeItemWidget
component.Does this PR introduce a breaking change?
This removes the
unstable_
prefix from theComposite
components. So this is going to break code that is currently using this module.