Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark Composite as stable #667

Merged
merged 3 commits into from
Jun 4, 2020
Merged

feat: Mark Composite as stable #667

merged 3 commits into from
Jun 4, 2020

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Jun 4, 2020

This PR marks the Composite module as stable, except the CompositeItemWidget component.

Does this PR introduce a breaking change?

This removes the unstable_ prefix from the Composite components. So this is going to break code that is currently using this module.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 449da2b:

Sandbox Source
festive-fermat-rjpfc Configuration

@ariakit-bot
Copy link

ariakit-bot commented Jun 4, 2020

Deploy preview for reakit ready!

Built with commit 449da2b

https://deploy-preview-667--reakit.netlify.app

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #667 into next will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #667   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files         147      147           
  Lines        2706     2706           
  Branches      753      753           
=======================================
  Hits         2584     2584           
  Misses        122      122           
Impacted Files Coverage Δ
...ckages/reakit/src/Composite/CompositeItemWidget.ts 100.00% <ø> (ø)
...posite/__examples__/CompositeWithTooltip/index.tsx 100.00% <ø> (ø)
.../Composite/__examples__/DynamicComposite/index.tsx 73.07% <ø> (ø)
...posite/__examples__/NestedCompositeItems/index.tsx 100.00% <ø> (ø)
...__examples__/VirtualCompositeWithTooltip/index.tsx 100.00% <ø> (ø)
...__examples__/VirtualNestedCompositeItems/index.tsx 100.00% <ø> (ø)
...kages/reakit/src/Composite/__utils/getCurrentId.ts 100.00% <ø> (ø)
...xamples__/DialogWithCompositeWithTooltip/index.tsx 100.00% <ø> (ø)
...__/DialogWithVirtualCompositeWithTooltip/index.tsx 100.00% <ø> (ø)
packages/reakit/src/Form/FormRadioGroup.tsx 94.44% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575f798...449da2b. Read the comment docs.

@diegohaz diegohaz merged commit 5e01f4c into next Jun 4, 2020
@diegohaz diegohaz deleted the feat/stable-composite branch June 4, 2020 03:18
@gziolo
Copy link

gziolo commented Jun 21, 2020

I’m aware that it was unstable API and it was fine to remove it 😃

However this removal of unstable prefix l, it causes issues In WordPress packages. See WordPress/gutenberg#23332. When someone is on older version of WordPress packages that worked with Reakit 1.0, it stops working with Reakit 1.1 because references are now invalid. Would you consider keeping aliases until Reakit 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants