Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post: announcing two-factor authentication #333

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Blog post: announcing two-factor authentication #333

merged 4 commits into from
Nov 21, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 6, 2024 •
edited by github-actions bot
Loading

@stsewd stsewd requested a review from a team as a code owner November 6, 2024 21:00
@stsewd stsewd requested a review from ericholscher November 6, 2024 21:00
ericholscher
ericholscher approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bit more explaining here would be good, and perhaps a screenshot? :)

content/posts/two-factor-authentication.md Outdated Show resolved Hide resolved
@stsewd
Copy link
Member Author

stsewd commented Nov 18, 2024

and perhaps a screenshot? :)

Not sure what to put as screenshot, the page asking for the codes? The page showing the user to scan the QR? 🤔

@ericholscher
Copy link
Member

I think either works, or we can just not do a screenshot, and just use a stock image for the header image.

@stsewd
Copy link
Member Author

stsewd commented Nov 18, 2024

I think either works, or we can just not do a screenshot, and just use a stock image for the header image.

I'm using this image https://github.com/readthedocs/website/blob/9d683296542bd0d676994d74fde1d009e71ecd85/content/images/2fa.jpg, or do you prefer something more 2fa related?

@humitos
Copy link
Member

humitos commented Nov 18, 2024

I'm using this image 9d68329/content/images/2fa.jpg, or do you prefer something more 2fa related?

That image is huge, you should resize it to 1000px wide (similar to others)

@stsewd stsewd requested a review from ericholscher November 21, 2024 15:07
@ericholscher ericholscher mentioned this pull request Nov 21, 2024
Open
@stsewd stsewd merged commit bc034e4 into main Nov 21, 2024
4 checks passed
@stsewd stsewd deleted the 2fa branch November 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @ericholscher @humitos