Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrading our build process to webpack 5 #23

Merged
merged 1 commit into from
Sep 17, 2021
Merged

feat: upgrading our build process to webpack 5 #23

merged 1 commit into from
Sep 17, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Sep 16, 2021

🧰 What's being changed?

There's been a lot of security issues with Webpack@4 that have been clogging up npm audit so I've decided to finally rip the bandaid off and upgrade us here.

🧪 Testing

  • Does npm build work?

@erunion erunion added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 16, 2021
kellyjosephprice
kellyjosephprice approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • npm run build

@erunion erunion merged commit de0df3e into main Sep 17, 2021
@erunion erunion deleted the feat/webpack5 branch September 17, 2021 16:35
@erunion erunion mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erunion @kellyjosephprice @rafegoldberg